Add translation status field to replace approved & fuzzy about pontoon

[bugzilla-to-github]

Comment Author: Alex Kosiacka <[email protected]>

Hi,

I've had a look on the bug and would love to work on it. I suspect the cause is that you're double-counting translations by separating fuzzy and approved translations. It looks like it's possible for a translation to be both approved and fuzzy in the database at once. Perhaps a better solution overall would be to have a single variable keeping track of the current state, instead of booleans for each state.

[bugzilla-to-github]

Comment Author: @mathjazz

Alex,

Thank you for looking into this bug. I like your idea of using e.g. status field with different states instead of separate fields.

I'm NIing :Osmose, who has been working on refactoring Stats recently and probably has an opinion on this.

[bugzilla-to-github]

Comment Author: @Osmose

As long as we are confident that fuzzy, approved, and unapproved are all mutually exclusive, a single state field for them is a fine idea. We can use a PositiveIntegerField with some choices for the actual field itself.

Are there any other states a translation can be in that we'd want to add to the list? Is there a better term than "fuzzy" for what the fuzzy status represents?

[bugzilla-to-github]

Comment Author: @mathjazz

They are mutually exclusive.

The term fuzzy comes from the PO file format and since it's the only file format using this property, I don't see the point in renaming it.

We made add another state later (rejected) if we add an option to reject unapproved translations. That would allow us to split unapproved strings into 2 groups - rejected ("triaged") and unapproved ("non-triaged"). But that's not the topic of this bug.

[bugzilla-to-github]

Comment Author: @mathjazz

*** Bug #1226421 has been marked as a duplicate of this bug. ***