Comments (8)
Since you asked for my opinion on the colour of that fancy new bikeshed :)
(It is in markdown for easy reading of the template, but we understand bugzilla will likely render it as plain text. That's fine.)
Maybe it should just be in plaintext to start with. It's kind of annoying having to look through the table markup when people use it. It would also avoid people having to rename the file manually to .txt so that it gets displayed inline in bugzilla.
from data-review.
Attach the completed Request Form to the bug, or paste the contents as a comment in the Issue
Personally, I'd like to discourage the "pasting into a comment" option. It makes the bug a lot noisier when there are a few iterations and it's harder to see which version of the data review request got approved. Also, it prevents us from using an r? flag.
from data-review.
Personally, I'd like to discourage the "pasting into a comment" option. It makes the bug a lot noisier when there are a few iterations and it's harder to see which version of the data review request got approved. Also, it prevents us from using an r? flag.
I tried to specify that it's specifically for an Issue instead of a bug... but maybe we shouldn't be bending over backwards to supporting a GitHub-based flow for Data Review?
from data-review.
Yeah, we should probably encourage a Bugzilla flow as much as possible. For example, the Activity Stream puts their data review requests on Bugzilla even though they use GitHub for development. I find that easier to deal with because the Bugzilla notifications / reminders are much better.
from data-review.
This rewording answers the questions I had about the instructions. (The other piece of confusion was the first item, saying " Create a bug using the data review bug form", which I thought both meant there was a custom form and which I thought meant that I shouldn't reuse the bug.)
from data-review.
I've made some changes.
@fmarier Want to review the diff? https://wiki.mozilla.org/index.php?title=Firefox%2FData_Collection&type=revision&diff=1201350&oldid=1200054
from data-review.
I've made some changes.
It looks much better!
from data-review.
Alrighty, any further tweaks can come via follow-ups. Closing this bug.
from data-review.
Related Issues (14)
- [request.md] Highlight that "The Firefox Data Collection Preference" is an acceptable option for Question 8 HOT 1
- It is unclear that renewing probes requires Data Collection Review
- [request.md] Permanent Telemetry collections must have an individual's email address in alert_emails and an automated test
- [wiki] Category 3 language for opt-out eligibility on release is a little awkward HOT 3
- Wiki changes
- CODE_OF_CONDUCT.md file missing
- The form is too long and discouraging me from adding telemetry probes HOT 3
- Amend current review process for other types of Firefox data collection requests HOT 2
- [request_renewal.md] doesn't require responsible individual HOT 3
- Collect a List of Common Resources for Reviewers HOT 4
- Create a question around private browsing behavior HOT 3
- the form doesn't copy/paste to bugzilla well HOT 2
- wiki page doesn't say which product + component to file the bug HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data-review.