Coder Social home page Coder Social logo

Comments (8)

fmarier avatar fmarier commented on July 19, 2024

Since you asked for my opinion on the colour of that fancy new bikeshed :)

(It is in markdown for easy reading of the template, but we understand bugzilla will likely render it as plain text. That's fine.)

Maybe it should just be in plaintext to start with. It's kind of annoying having to look through the table markup when people use it. It would also avoid people having to rename the file manually to .txt so that it gets displayed inline in bugzilla.

from data-review.

fmarier avatar fmarier commented on July 19, 2024

Attach the completed Request Form to the bug, or paste the contents as a comment in the Issue

Personally, I'd like to discourage the "pasting into a comment" option. It makes the bug a lot noisier when there are a few iterations and it's harder to see which version of the data review request got approved. Also, it prevents us from using an r? flag.

from data-review.

chutten avatar chutten commented on July 19, 2024

Personally, I'd like to discourage the "pasting into a comment" option. It makes the bug a lot noisier when there are a few iterations and it's harder to see which version of the data review request got approved. Also, it prevents us from using an r? flag.

I tried to specify that it's specifically for an Issue instead of a bug... but maybe we shouldn't be bending over backwards to supporting a GitHub-based flow for Data Review?

from data-review.

fmarier avatar fmarier commented on July 19, 2024

Yeah, we should probably encourage a Bugzilla flow as much as possible. For example, the Activity Stream puts their data review requests on Bugzilla even though they use GitHub for development. I find that easier to deal with because the Bugzilla notifications / reminders are much better.

from data-review.

dbaron avatar dbaron commented on July 19, 2024

This rewording answers the questions I had about the instructions. (The other piece of confusion was the first item, saying " Create a bug using the data review bug form", which I thought both meant there was a custom form and which I thought meant that I shouldn't reuse the bug.)

from data-review.

chutten avatar chutten commented on July 19, 2024

I've made some changes.

@fmarier Want to review the diff? https://wiki.mozilla.org/index.php?title=Firefox%2FData_Collection&type=revision&diff=1201350&oldid=1200054

from data-review.

fmarier avatar fmarier commented on July 19, 2024

I've made some changes.

It looks much better!

from data-review.

chutten avatar chutten commented on July 19, 2024

Alrighty, any further tweaks can come via follow-ups. Closing this bug.

from data-review.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.