Coder Social home page Coder Social logo

Comments (4)

muffinresearch avatar muffinresearch commented on June 7, 2024

Thinking more about this - I'm not convinced this would be the right approach. Do we really want something that does validation in a request?

I don't know how the current setup works precisely but shouldn't validation be queued and dealt with by validation workers? If so we probably don't need an API unless the queue and workers need to be dealt with outside of AMO in which case this is a much bigger bug.

from addons-linter.

tofumatt avatar tofumatt commented on June 7, 2024

Yeah, this makes sense. I think the website might be a cool demo, but an HTTP API for validation wouldn't be world-facing.

This then becomes a bit of an add-ons rewrite question. If we want to do a bunch of micro-services that all talk HTTP to one another, writing a request-based API could be a thing, but even then the worker idea seems saner.

I could imagine an API that accepts a file and gives back a "validation request ID" one could poll for results with. But not a validation tied to the request/response cycle. Seems like an invitation for a timeout error if nothing else.

from addons-linter.

tofumatt avatar tofumatt commented on June 7, 2024

An aside re: "making sure we aren't too CLI":

Part of the intent to this bug was making sure we weren't too CLI-focused. But we started by outputting JSON before we even had pretty CLI output, so we are at least able to send our validation results off to places as-is.

from addons-linter.

tofumatt avatar tofumatt commented on June 7, 2024

We don't want to build an Express API after all; what we really want is the ability to interact with Celery and run this in a queue from Olympia.

I'll close this as I don't think it's actually needed anymore; we don't need a direct web interface to the validator.

from addons-linter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.