Comments (6)
pdehaan
commented on September 2, 2024
For future reference, here's the initial fallout from a simple git clone and pep8 . command:
$ git clone [email protected]:mozilla-services/services-test.git
Cloning into 'services-test'...
remote: Counting objects: 1210, done.
remote: Total 1210 (delta 0), reused 0 (delta 0), pack-reused 1210
Receiving objects: 100% (1210/1210), 197.47 KiB | 0 bytes/s, done.
Resolving deltas: 100% (551/551), done.
Checking connectivity... done.
$ cd services-test
$ pep8 .
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:8:80: E501 line too long (80 > 79 characters)
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:16:12: W291 trailing whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:17:1: W293 blank line contains whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:21:44: E261 at least two spaces before inline comment
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:21:46: W291 trailing whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:22:78: E231 missing whitespace after ','
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:22:80: E501 line too long (81 > 79 characters)
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:23:55: W291 trailing whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:24:80: E501 line too long (83 > 79 characters)
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:24:81: E231 missing whitespace after ','
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:25:80: E501 line too long (89 > 79 characters)
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:25:87: E231 missing whitespace after ','
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:26:50: W291 trailing whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:28:66: W291 trailing whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:29:66: W291 trailing whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:35:1: E302 expected 2 blank lines, found 1
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:37:1: W293 blank line contains whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:38:1: E302 expected 2 blank lines, found 1
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:39:1: W293 blank line contains whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:46:1: W293 blank line contains whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:49:1: E302 expected 2 blank lines, found 1
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:51:5: E265 block comment should start with '# '
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:56:1: W293 blank line contains whitespace
./autopush/e2e-test/tests/pop-notification.sikuli/pop-notification.py:90:11: W292 no newline at end of file
./kinto/api-test/test_kinto_buckets.py:24:80: E501 line too long (85 > 79 characters)
./kinto/api-test/test_kinto_buckets.py:32:80: E501 line too long (93 > 79 characters)
./kinto/api-test/test_kinto_buckets.py:44:80: E501 line too long (86 > 79 characters)
./kinto/api-test/test_kinto_buckets.py:75:80: E501 line too long (94 > 79 characters)
./kinto/api-test/test_kinto_buckets.py:84:80: E501 line too long (96 > 79 characters)
./kinto/api-test/test_kinto_buckets.py:94:80: E501 line too long (94 > 79 characters)
./kinto/api-test/test_kinto_buckets.py:102:80: E501 line too long (83 > 79 characters)
./kinto/api-test/test_kinto_buckets.py:109:80: E501 line too long (93 > 79 characters)
./kinto/api-test/test_kinto_buckets.py:121:80: E501 line too long (89 > 79 characters)
./kinto/api-test/test_kinto_collections.py:24:80: E501 line too long (85 > 79 characters)
./kinto/api-test/test_kinto_collections.py:32:80: E501 line too long (86 > 79 characters)
./kinto/api-test/test_kinto_collections.py:45:80: E501 line too long (86 > 79 characters)
./kinto/api-test/test_kinto_collections.py:61:80: E501 line too long (94 > 79 characters)
./kinto/api-test/test_kinto_collections.py:70:80: E501 line too long (96 > 79 characters)
./kinto/api-test/test_kinto_collections.py:78:80: E501 line too long (94 > 79 characters)
./kinto/api-test/test_kinto_collections.py:89:80: E501 line too long (82 > 79 characters)
./kinto/api-test/test_kinto_collections.py:106:80: E501 line too long (86 > 79 characters)
./kinto/api-test/test_kinto_collections.py:119:80: E501 line too long (89 > 79 characters)
./kinto/api-test/test_kinto_collections.py:133:80: E501 line too long (89 > 79 characters)
./kinto/api-test/test_kinto_collections.py:142:80: E501 line too long (105 > 79 characters)
./kinto/api-test/test_kinto_groups.py:25:80: E501 line too long (85 > 79 characters)
./kinto/api-test/test_kinto_groups.py:33:80: E501 line too long (92 > 79 characters)
./kinto/api-test/test_kinto_groups.py:45:80: E501 line too long (86 > 79 characters)
./kinto/api-test/test_kinto_groups.py:73:80: E501 line too long (92 > 79 characters)
./kinto/api-test/test_kinto_groups.py:92:80: E501 line too long (86 > 79 characters)
./kinto/api-test/test_kinto_groups.py:99:80: E501 line too long (105 > 79 characters)
./kinto/api-test/test_kinto_groups.py:121:80: E501 line too long (89 > 79 characters)
./kinto/api-test/test_kinto_heartbeat.py:9:80: E501 line too long (93 > 79 characters)
./kinto/api-test/test_kinto_records.py:93:80: E501 line too long (94 > 79 characters)
./kinto/api-test/test_kinto_records.py:113:80: E501 line too long (94 > 79 characters)
./kinto/api-test/test_kinto_records.py:133:80: E501 line too long (94 > 79 characters)
./kinto/api-test/test_kinto_records.py:166:80: E501 line too long (94 > 79 characters)
./msisdn-gateway/e2e-test/fabfile.py:4:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/fabfile.py:8:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/test/control-script.py:14:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/test/control-script.py:15:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:16:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:17:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:18:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:20:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/test/control-script.py:21:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:22:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:23:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:24:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:24:80: E501 line too long (102 > 79 characters)
./msisdn-gateway/e2e-test/test/control-script.py:25:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:26:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:28:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:29:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:29:80: E501 line too long (81 > 79 characters)
./msisdn-gateway/e2e-test/test/control-script.py:30:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:30:80: E501 line too long (106 > 79 characters)
./msisdn-gateway/e2e-test/test/control-script.py:31:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:32:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:33:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:33:80: E501 line too long (107 > 79 characters)
./msisdn-gateway/e2e-test/test/control-script.py:34:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:36:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:37:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:37:80: E501 line too long (90 > 79 characters)
./msisdn-gateway/e2e-test/test/control-script.py:38:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:39:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:40:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:40:80: E501 line too long (87 > 79 characters)
./msisdn-gateway/e2e-test/test/control-script.py:42:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/test/control-script.py:43:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:44:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:44:60: W291 trailing whitespace
./msisdn-gateway/e2e-test/test/control-script.py:45:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:47:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:48:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:48:26: W291 trailing whitespace
./msisdn-gateway/e2e-test/test/control-script.py:49:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:51:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:52:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:53:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:55:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:56:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:57:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:59:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:61:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:62:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:63:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:64:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:66:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:66:80: E501 line too long (83 > 79 characters)
./msisdn-gateway/e2e-test/test/control-script.py:67:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:68:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:68:80: E501 line too long (89 > 79 characters)
./msisdn-gateway/e2e-test/test/control-script.py:69:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:73:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:73:8: W292 no newline at end of file
./services-marionette/firefox-services-tests/apps/base.py:50:80: E501 line too long (80 > 79 characters)
./services-marionette/firefox-services-tests/apps/base.py:61:80: E501 line too long (80 > 79 characters)
./services-marionette/firefox-services-tests/apps/base.py:68:80: E501 line too long (80 > 79 characters)
./services-marionette/firefox-services-tests/apps/fxa/login.py:29:80: E501 line too long (98 > 79 characters)
./services-marionette/firefox-services-tests/apps/fxa/login.py:54:80: E501 line too long (83 > 79 characters)
./services-marionette/firefox-services-tests/apps/pocket/app.py:35:1: W391 blank line at end of file
from services-test.
pdehaan
commented on September 2, 2024
Questions:
- Do we care about pep8?
- Do we care about all rules? Do we ignore "E501 line too long"?
- Can we ignore certain folders from pep8 linting? We don't care about the "./autopush/e2e-test/tests/pop-notification.sikuli" folder since it's generated code.
Ignoring "E501" and the ".sikuli" folder, the output is reduced to this super manageable list:
$ pep8 . | grep -v ": E501 line too long" | grep -v ".sikuli"
./msisdn-gateway/e2e-test/fabfile.py:4:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/fabfile.py:8:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/test/control-script.py:14:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/test/control-script.py:15:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:16:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:17:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:18:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:20:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/test/control-script.py:21:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:22:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:23:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:24:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:25:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:26:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:28:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:29:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:30:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:31:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:32:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:33:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:34:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:36:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:37:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:38:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:39:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:40:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:42:1: E302 expected 2 blank lines, found 1
./msisdn-gateway/e2e-test/test/control-script.py:43:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:44:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:44:60: W291 trailing whitespace
./msisdn-gateway/e2e-test/test/control-script.py:45:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:47:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:48:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:48:26: W291 trailing whitespace
./msisdn-gateway/e2e-test/test/control-script.py:49:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:51:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:52:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:53:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:55:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:56:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:57:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:59:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:61:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:62:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:63:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:64:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:66:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:67:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:68:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:69:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:73:1: W191 indentation contains tabs
./msisdn-gateway/e2e-test/test/control-script.py:73:8: W292 no newline at end of file
./services-marionette/firefox-services-tests/apps/pocket/app.py:35:1: W391 blank line at end of file
from services-test.
rpappalax
commented on September 2, 2024
Questions:
- Do we care about pep8?
** we do! - Do we care about all rules? Do we ignore "E501 line too long"?
** we need to be able to tweak the rules when necessary
** flake8 is easy to use http://flake8.readthedocs.org/en/latest/config.html - Can we ignore certain folders from pep8 linting? We don't care about the "./autopush/e2e-test/tests/pop-notification.sikuli" folder since it's generated code. ( see note 2)
tox is prob a good idea. may be overkill for just linting, but it would also allow us to run smoke smoke tests on travis.
from services-test.
pdehaan
commented on September 2, 2024
Ah!
Answers:
I can add a .pep8 file to the root folder and add this:
[pep8]
ignore = E501
exclude = **/*.sikuli/*Then run pep8 using this:
$ pep8 .
I'll look into flake8.
from services-test.
pdehaan
commented on September 2, 2024
Here's my ESLint config:
extends: eslint:recommended
env:
es6: true
node: true
mocha: true
globals:
marionette: true
rules:
no-console: 0
no-unused-vars: [2, {vars: all, args: none}]
And here's the current output:
$ eslint .
/Users/pdehaan/dev/tmp/del/services-test/dashboard/e2e-test/config/stage.js
3:11 error Unexpected trailing comma comma-dangle
/Users/pdehaan/dev/tmp/del/services-test/dashboard/e2e-test/tests/dashboard.js
6:5 error "restmail" is defined but never used no-unused-vars
7:5 error "P" is defined but never used no-unused-vars
/Users/pdehaan/dev/tmp/del/services-test/loop/e2e-test/tests/loop_signup.js
2:5 error "expect" is defined but never used no-unused-vars
✖ 4 problems (4 errors, 0 warnings)
from services-test.
pdehaan
commented on September 2, 2024
Here's the current E501 errors via Flake8: https://gist.github.com/pdehaan/27010daff64c251cb012
from services-test.
Related Issues (20)
- Migrate tests and page objects back to services-test HOT 6
- Abort job when mozilla-central is unavailable (i.e. during maintanence job)
- Remove MSISDN-Gateway tests
- Add autopush loadtest config file
- Update shavar/e2e-test/prefs.ini to reflect new shavar lists
- Add opengraph test HOT 2
- Enable mozplugin files for shavar
- Add autopush pytest for URL checks HOT 1
- Remove deprecated projects: loop, msisdn-gateway, etc.
- Update README with team info, links, communication, contributor info, etc. HOT 2
- Tag a 0.1.0 release HOT 1
- Remove unused files: _shared, VERSION, Dockerfile
- Add Ops pipeline test script runner HOT 1
- Update autopush prefs.ini w/ new e2e-test link
- Migrate Kinto project to separate test repo(s) HOT 1
- Create Dockerfile for config-check
- shavar - prefs remove gethash URL from defaults HOT 1
- services-qa-jenkins in Read Me link Not found
- Remove tests from autopush project and add redirect
- CODE_OF_CONDUCT.md file missing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from services-test.