syslog decoder unable to parse structured data about lua_sandbox

[trink]

Yeah param_value would have to allow the escaped versions of ", ', ] but it can be fixed up as well.

[jedisct1]

Indeed, something like

local esc             = l.P'\\'
local param_value_esc = l.S'"\\]'
local param_value     = ((octet - param_value_esc) + (esc * param_value_esc))^0

might be enough to fix it.

[trink]

It would still have to work for something like "foo\bar". The sd_name grammar can be simplified too. Are you interested in submitting a PR for this?

[jedisct1]

foo\bar would have to be written foo\\bar. I don't think that foo\bar is correct according to the RFC.

I can certainly submit a PR for this.

[jedisct1]

Stupid question: aren't we supposed to capture (name, value) pairs here?

[trink]

That is definitely an option, otherwise it will just capture the entire string. Breaking it into individual message fields would be very useful we just didn't have the need (you are the first to use the structured format)

[jedisct1]

Having the parser return a table with the fields is probably better than returning the entire string that will have to be parsed anyway.

I'm gonna add this to my initial pull request.

[jedisct1]

Can you look at the PR again?

foo\bar is now allowed, and the captured fields are returned as a table.

[jedisct1]

Can you review the current PR?