Coder Social home page Coder Social logo

Comments (10)

jandem avatar jandem commented on June 11, 2024 1

@beatrice-acasandrei I think that works for now. Maybe we can put a banner on the relevant pages to warn people about this bug, because the data is kind of misleading atm?

from firefox-performance-dashboards.

davehunt avatar davehunt commented on June 11, 2024

@beatrice-acasandrei is going to look into this when she's back from PTO next week.

from firefox-performance-dashboards.

jandem avatar jandem commented on June 11, 2024

Ping? It would be great to have this fixed :-)

from firefox-performance-dashboards.

davehunt avatar davehunt commented on June 11, 2024

Thanks for the ping. @beatrice-acasandrei any further progress getting to the bottom of this issue?

from firefox-performance-dashboards.

beatrice-acasandrei avatar beatrice-acasandrei commented on June 11, 2024

The results from chrome and chromium are sharing the same signature hash. Since the logic is relying on the signature hash it is not able to differentiate between chrome and chromium results. Same issue is with the generated link for the Perfherder Graph View.
One workaround can be to go to Perfherder's Graph and add data manually for chromium from the 'Add test data' button.
I have upcoming PTO and we might take a while before we'll be able to fix this issue.

from firefox-performance-dashboards.

davehunt avatar davehunt commented on June 11, 2024

It sounds like there may be an underlying bug in Perfherder that's not distinguishing the signatures for subtests for chrome vs chromium. It's also affecting the suite level value, although only when clicking the Perfherder link (both chrome/chromium are displayed but with a shared series). This seems to only affect the benchmark detail view (the overview appears to be fine). This suggests we might be able to resolve this in AWFY but I suspect we need to get to the root cause of the shared signature issue. With PTO affecting the team over the next couple of weeks it's unlikely we're going to have a fix soon. The recommended workaround is to use Perfherder graphs view and add the tests you're interested in.

from firefox-performance-dashboards.

davehunt avatar davehunt commented on June 11, 2024

@jandem I've created a redash query that takes a platform and suite as parameters and builds a Perfherder graph link for all applications: https://sql.telemetry.mozilla.org/queries/89799. It's not perfect, as it includes Firefox for both autoland and mozilla-central, but it may be useful as a workaround for this issue?

from firefox-performance-dashboards.

jandem avatar jandem commented on June 11, 2024

@davehunt thanks for doing that! I'll give it a try :)

from firefox-performance-dashboards.

davehunt avatar davehunt commented on June 11, 2024

I've improved the query to only show autoland for Firefox and only mozilla-central for non-Firefox.

from firefox-performance-dashboards.

beatrice-acasandrei avatar beatrice-acasandrei commented on June 11, 2024

@jandem Hi! Does the query provided by Dave fulfill your needs for now? This issue is more complex than we initially anticipated and might take a while until it's fixed.

from firefox-performance-dashboards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.