first example crashes about aiohttp-asgi

[jrobbins-LiveData]

Changing this code (startup=True) to (startup=False) prevents the crash.

This crashes

# [Optional]
asgi_resource.lifespan_mount(
    aiohttp_app,
    startup=True,
    # By default starlette didn't
    # handle "lifespan.shutdown"
    shutdown=False,
)

This does not crash, but presumably then doesn't do anything useful?

# [Optional]
asgi_resource.lifespan_mount(
    aiohttp_app,
    startup=False,
    # By default starlette didn't
    # handle "lifespan.shutdown"
    shutdown=False,
)

[jrobbins-LiveData]

The issue appears to be due to the fact that lifespan_mount instances an asyncio Queue before aiohttp has created the asyncio event loop.

    def lifespan_mount(self, app: Application, startup=True, shutdown=False):
        receives = asyncio.Queue()      # type: asyncio.Queue

Since there is no event loop, asyncio.Queue() creates one(!)

    def __init__(self, maxsize=0, *, loop=None):
        if loop is None:
            self._loop = events.get_event_loop()

Which is not what aiohttp expects in its web.run_app().

[jrobbins-LiveData]

Using a coroutine to web.run_app() seems to fix the problem. See this doc which states

The coroutine based approach allows to perform async IO before making an app.

from aiohttp import web
from fastapi import FastAPI
from starlette.requests import Request as ASGIRequest

from aiohttp_asgi import ASGIResource

asgi_app = FastAPI()


@asgi_app.get("/asgi")
async def root(request: ASGIRequest):
    return {
        "message": "Hello World",
        "root_path": request.scope.get("root_path")
    }


async def app_factory():
    aiohttp_app = web.Application()

    # Create ASGIResource which handle
    # any request startswith "/asgi"
    asgi_resource = ASGIResource(
        asgi_app,
        root_path="/asgi"
    )

    # Register resource
    aiohttp_app.router.register_resource(
        asgi_resource
    )

    # [Optional]
    asgi_resource.lifespan_mount(
        aiohttp_app,
        startup=True,
        # By default starlette didn't
        # handle "lifespan.shutdown"
        shutdown=False,
    )

    return aiohttp_app

# Start the application
web.run_app(app_factory())

[mosquito]

Fixed in 0.5.0