Comments (5)
In another use case, the issue with factor was also discovered. So when the metadata column is factor, ComplexHeatmap tries to map to numeric value of factor level, causing similar issue.
We should add another internal call to convert metadata columns to characters if/when they are factors.
So the fix should contain two steps: 1. convert from factor to string then 2. replace NA values with βNAβ
from gamblr.viz.
I think there is a related issue here that should be resolved. Have those standard columns in the metadata (e.g. pathology) always been set as factors or is this a recent change?
from gamblr.viz.
I think I got the idea of what is going on
from gamblr.viz.
In the recent update that I made to get rid of colors in the annotation colors that are displayed when no values for them are present in the metadata (PR #36, issue #35) I did not account for the metadata columns that had been passed to the prettyOncoplot as factors. This resulted in a bug that during subsetting of the colors list, the NA values were not properly handled, which generated this issue.
There was already a call that was converting factors to the characters, but it was done during subsetting for the remaining colors, and to fix the reported issue I have moved this call to occur prior to the color subsetting. Now the example works properly and can handle the sex column that is passed as factor. Here is the sample plot:
from gamblr.viz.
This is fixed in PR #44
from gamblr.viz.
Related Issues (20)
- remove ggsci dependency from Description HOT 1
- `heatmap_mutation_frequency_bin` shows pathology even when not specified HOT 1
- `heatmap_mutation_frequency_bin` lost rotation of the column title HOT 1
- Error in `prettyOncoplot` HOT 1
- `prettyOncoplot` is missing a step to assign POS/NEG colours HOT 7
- Website/tutorials for GAMBLR.viz HOT 1
- error in `prettyCoOncoplot` HOT 1
- Ensure viz passes the devtools check HOT 1
- setup github actions for this package
- drop reshape2 dependency
- drop cowplot dependency
- drop plotly dependency
- Develop ggplot2-implemented lollipop plots
- README needs update
- `prettyOncoplot` bugs
- handling of custom colors for numeric annotations HOT 1
- Support custom ordering in prettyForestPlot
- prettyChromoplot does not take projection/genome_build as argument HOT 1
- prettyChromoplot doesn't allow labelling of cytobands HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gamblr.viz.