Custom Expiry not functioning as expected about ng2-idle

[markmaynard]

Sorry to bug you but I see responses on other issues, is there something my issue is missing?

[moribvndvs]

@markmaynard Sorry, I've been busy at work and haven't had time to reproduce the issue. If you think you've got a handle on what needs to change to get it working, feel free to submit a pull request. I might be able to take a look this weekend.

[markmaynard]

I thought I had a fix but I was incorrect. The problem seems to be that activity sets a new timeout time in my cookie, but none of the other tabs actually check the cookie to see that this timeout has been extended. What I think need to happen is that when a timeout occurs on a tab, it first checks the cookie(or other shared storage) to see if is time is greater than the time in the cookie. If not it sets a new timer for the difference between stored_time and now.

[moribvndvs]

Ah, right. So, evergreen browsers (except Edge) support an onChanged event for cookies. That would be ideal (and most analogous to how I handle it via storage in the original ng-idle). However, we'd still need a way to handle browsers that don't support this. It may make sense to create a custom interrupt source that triggers a function at intervals (say, 1 second) to see if the cookie value has changed. If it has, trigger the interrupt. This, in concert with your CookieExpiry should handle activity from other tabs.

[roupify]

If localStorage is an option for you, a new release of ng2-idle has been made last week on tag v2.0.0-beta.6.

[markmaynard]

I have a cookie storage version that works fine in that it is a centralized store for the timeout value. The problem I ran into is that the idle timeout is set by all the open tabs but the interval in the watch function does not check the the updated values. The change I PRed should fix that.

[Splaktar]

#37 was merged. Should this issue be closed now?

[markmaynard]

Yes, sorry, closing now.