Coder Social home page Coder Social logo

Comments (2)

mootensai avatar mootensai commented on June 1, 2024

How so? could you explain what you did and show the Model that use it?

from yii2-relation-trait.

Ziggizag avatar Ziggizag commented on June 1, 2024

Models are complex with many relations.

But your overall code is piece of shit.

First of all - not each and every instance of ActiveQuery is a relation!!!

Looka at your code - first of all - you effectively rip through all "get" queries here:

try {
$rel = call_user_func(array($this, $method->name));
if ($rel instanceof ActiveQuery) {
$name = lcfirst(preg_replace('/^get/', '', $method->name));
$stack[$name]['name'] = lcfirst(preg_replace('/^get/', '', $method->name));
$stack[$name]['method'] = $method->name;
$stack[$name]['ismultiple'] = $rel->multiple;
$stack[$name]['modelClass'] = $rel->modelClass;
$stack[$name]['link'] = $rel->link;
$stack[$name]['via'] = $rel->via;
}
} catch (ErrorException $exc) {

then - you fuck delete all records as a madman:

if (!$isNewRecord) {
//DELETE WITH 'NOT IN' PK MODEL & REL MODEL
if ($isManyMany) {
// Many Many
$query = ['and', $notDeletedFK];
foreach ($notDeletedPK as $attr => $value) {
$notIn = ['not in', $attr, $value];
array_push($query, $notIn);
}
try {
$relModel->deleteAll($query);
} catch (IntegrityException $exc) {
$this->addError($name, "Data can't be deleted because it's still used by another data.");
$error = true;
}
} else {
// Has Many
$query = ['and', $notDeletedFK, ['not in', $relPKAttr[0], $notDeletedPK]];
if (!empty($notDeletedPK)) {
try {
$relModel->deleteAll($query);
} catch (IntegrityException $exc) {
$this->addError($name, "Data can't be deleted because it's still used by another data.");
$error = true;
}
}
}
}

You are a criminal - your fucking plugin nearly killed my database!

from yii2-relation-trait.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.