'firstDraw' event is dispatch multiple times as per nested child(ren) about montage

[heatherdouglass]

Hello, do you have a specific example? I have not been able to reproduce this yet. Thanks!

[joseeight]

It happens whether in any way to handle the event:

this.addEventListener('firstDraw', this, false);

or

this.addEventListener('firstDraw', function (e) {//handle});

[francoisfrisch]

This was changed for gh-17, maybe the firstDraw event should have bubbles set to false

[heatherdouglass]

I can reproduce it now. I must have been testing against the wrong branch previously. Thanks.

[francoisfrisch]

or a better solution would be to removeEventListener once the firstDraw event has been handled.

[joseeight]

So, is this an expected new feature? Just want to make sure we know how 'firstDraw' is expected to work.

[francoisfrisch]

it's not specific to firstDraw, all events dispatched on a component now bubble up the component tree by default

[mczepiel]

Just to be extremely specific:

As mentioned, events that canBubble should bubble up the component hierarchy, hopefully events that cannot bubble are not bubbling. If you are seeing the latter behavior anywhere, that would be considered a bug.

I think it's reasonable to expect firstDraw to bubble in case a parent does care to react to some particular children meeting some criteria drawing the first time. This does mean that you will need to check the event.target in your handler and that once you have handled the firstDraw for yourself, if that's all you cared about, then you probably should remove yourself as a listener.

[joseeight]

Thanks Mike, Francios also clarified that, I tested it, and it works, the first element to dispatch the event is the parent as expected, so this does not cause any problems.