Compilation fails when building without udev about libmonome

[tehn]

is udev not a requirement?

[simonvanderveldt]

is udev not a requirement?

@tehn AFAIK not, building libmonome will fall back to using sysfs if udev is missing.
I gathered this from #1 as well as

libmonome/wscript

Line 52 in 2792f1e

mandatory=False,

and @wrl's answer on #monome on IRC.

The above error is caused by the code for the sysfs implementation, that's why it only triggers when building without udev.

[tehn]

ok. so should udev be required?

[simonvanderveldt]

ok. so should udev be required?

No, it doesn't have to be, sysfs alone can be enough.
I think I know how to fix this issue, will give it a try this weekend.

[simonvanderveldt]

Whilst for some reason I'm currently no longer able to reproduce this issue we should fix the asprintf warning because it opens the door to vulnerabilities. For some more info see here https://web.archive.org/web/20090505140305/http://blogs.23.nu:80/ilja/2006/10/antville-12995/

@wrl I think this would be the patch, does this look right?
I'm not sure if buf being NULL could cause any issues elsewhere in the code?

        path = strchr(path, '/') + 1;
 
-       asprintf(&buf, FTDI_PATH "/*/%s", path);
+  if (asprintf(&buf, FTDI_PATH "/*/%s", path) < 0) {
+         goto err_asprintf;
+  }
        glob(buf, 0, NULL, &gb);
        free(buf);
...
+ err_asprintf:
+	free(buf);