New Group for MSE/PE about dhkx

[monnand]

The group Ids are assigned according to RFC 2409 and RFC 3526. Since there are too much copy&paste work, I only put group 14 in the code (which is usually a good choice for most applications), and randomly picked two other groups.

Can you find your group in those RFCs? I think group id 3 was assigned in RFC 2409, section 6.3.

If the group was not assigned an ID. I think we may have three options:

• Let user directly new a DHGroup structure.
• Create another function to create groups which was not assigned an ID.
• Use negative values in GetGroup function to represent unassigned groups. (and make sure id 0 be the default group, which is group 14 now.)

All options above seems valid to me. So feel free to submit your pull request. I would be happy to accept it. The major (only?) user of this library is uniqush-conn. As long as you can make sure it is safe, then you are good.

[nhelke]

Thanks for you quick reply. The aforementioned prime does not appear to be in either RFC. If it is ok with you I'm going to write a patch to let users create their own groups. I think it is more flexible than using negative ids for non-standard groups.

[monnand]

Sure. Feel free to make your change.

[nhelke]

Thank you.