Coder Social home page Coder Social logo

Comments (2)

codepathreview avatar codepathreview commented on July 21, 2024

👍 Nice work! The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

  • As a reminder, there are two great style guides in the
    Swift community likeRay Wenderlich's Swift Style Guide and Github's Swift Style Guide
  • You can remove generated Xcode functions, if not used (e.g.
    override func didReceiveMemoryWarning() {
    super.didReceiveMemoryWarning()
    // Dispose of any resources that can be recreated.
    }
    )
  • Try to default to the Swift literal syntax instead of the long form (using [String: AnyObject] over Dictionary<String, AnyObject>).
  • You should always try to minimize the number of properties and methods that are public or internal (access is internal by default). Make the access private if the property or function doesn't need to be accessed outside the class.
  • In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response.
  • Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
  • Your images are loading synchronously. This will block the UI thread and make it so that your app appears frozen while the images are being downloaded.
  • Nice work setting up the proper modes for the images so that they are not stretched.
  • Nice work implementing the error message on network failure.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

Feel free to reach out, if you have any questions! I'd be glad to help! 😄

from rotten-tomatoes.

monisun avatar monisun commented on July 21, 2024

Thanks @jasdev for the helpful feedback!

from rotten-tomatoes.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.