Coder Social home page Coder Social logo

Comments (17)

therationalpi avatar therationalpi commented on August 27, 2024

I didn't realize someone put "you" as a keyword. That should be fixed. We probably should run through and fix up a bunch of the keywords.

I think the upcoming version has some new farewell scripts.

from monikamoddev.

Guardianvoir avatar Guardianvoir commented on August 27, 2024

Whenever I find a problem with Keywords or anything relating to the talk feature, I'll post it here.

from monikamoddev.

therationalpi avatar therationalpi commented on August 27, 2024

Just going to put in a basic help wanted here for someone to comb through script-topics for any "too common" keywords. Words like "of" "I" or "you" can be part of specific bi-gram keywords, but shouldn't be keywords by themselves.

from monikamoddev.

Guardianvoir avatar Guardianvoir commented on August 27, 2024

Whenever I say anything beginning with "I have", she'll usually respond with stuff like this.
screenshot0004
screenshot0005

from monikamoddev.

 avatar commented on August 27, 2024

Thanks for the report! We'll be ironing out any bugs for the next release, including these.

from monikamoddev.

 avatar commented on August 27, 2024

This issue has been resolved (as of now) by removing the keywords "you" and "herself" from script-topics. If any other problems arise after this, the issue should be re-opened. Otherwise, I recommend it be closed.

from monikamoddev.

Guardianvoir avatar Guardianvoir commented on August 27, 2024

She's still giving the speech when I say "I love you"

from monikamoddev.

therationalpi avatar therationalpi commented on August 27, 2024

Which version are you using, @Guardianvoir ?

from monikamoddev.

Guardianvoir avatar Guardianvoir commented on August 27, 2024

Lightweight Pre-re-release

from monikamoddev.

 avatar commented on August 27, 2024

Interesting, so it seems removing those keywords didn't entirely fix the problem. I'll do some more digging.

from monikamoddev.

 avatar commented on August 27, 2024

I've reinvestigated this issue and managed to track down another possible solution. After testing, it seems the issue was resolved. Saying "I love you" no longer warrants Monika to go on the spiel about herself.

As for the "I have" screenshots, that seems to be intentional. I hope this issue has been resolved. Can you double check when @therationalpi sends out another pre-release? @Guardianvoir

Screenshot (this test was repeated): https://gyazo.com/c6e0d88a64e5259bcb3169e3a08e001e

from monikamoddev.

Guardianvoir avatar Guardianvoir commented on August 27, 2024

I'll double check to make sure it's fixed. Thanks for reinvestigating this issue!

from monikamoddev.

 avatar commented on August 27, 2024

@Guardianvoir New pre-release is out. I'd appreciate if you checked ASAP.

from monikamoddev.

Guardianvoir avatar Guardianvoir commented on August 27, 2024

I tested the phrase "I love you" 10 times and she said "I love you too!" every time. It looks like it's fixed @Jxhnathan08 However, now her eyes look weird. It looks like someone drew over them.
screenshot0004

Edit: I forgot a comparison picture.
screenshot0001

from monikamoddev.

therationalpi avatar therationalpi commented on August 27, 2024

That's some of the new art we're going to use in the future. I think we're going to shelve it for the moment, since it could use a bit of polishing.

Thanks for testing for us!

from monikamoddev.

Guardianvoir avatar Guardianvoir commented on August 27, 2024

If you need my opinion on it, the eyes are too big and bright.

from monikamoddev.

therationalpi avatar therationalpi commented on August 27, 2024

Thanks for the feedback!

from monikamoddev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.