Soundtest interface about monikamoddev

[therationalpi]

Fixed it.

ba1a457

[therationalpi]

#26

While the whole suggestion here would be too much to implement, having Monika comment on the song you choose to play through Soundtest could be good.

Due to the nature of the DDLCModTemplate, this issue should be reviewed.

After a discussion in Discord, a draft for this system has been brought up.

A simple, accessible menu that can be accessed the following ways:

• The 'm' key. (Possibly assign another key for solely music skipping)
• Through the settings button.
• A small music icon.
• Dialogue-esque choice style. This allows Monika to comment on songs selected by the player.

A selection of songs can be chosen from this menu. Possible ideas include:

• Music/SFX from DDLC
• Selective choices, specifically piano pieces used from the community that can be framed as Monika playing for the player.

[ThePotatoGuy]

I was playing around a bit with screens and managed to create this:

It acts as an overlay, using screens game_menu and navigation to create a functioning menu. This menu is also dynamically created, so adding additional songs is as simple as adding to a list, defined in songs.music_choices. (I have not tested scrollbars, so that will have to be handled if we add a ton of songs.)

The screen is displayed upon pressing "m". Since its a screen, it should be easy to work with a gui button.

Also the screen is opened in a different context. I was unable to figure a way to workaround this, so the following flow occurs upon a music change:

1. User hits "m".
2. The python function select_track is executed.
3. The label display_music_selector is called in a new context, which launches the Music Menu screen as well as disables reopening the Music Menu if user hits "m" again.
4. User clicks a song. The song is stored in songs.selected_track. Flow returns to the select_track function.
5. select_track checks if songs.selected_track is different than the currently playing track songs.current_track. If it is different, the selected track is played and the current track is set to the selected track

In addition, I added persistent.current_track which stores the currently playing track. I added some logic to ch30_autoload which checks for this and plays this track accordingly.

Code comparison is here

Forgot to mention that the song "buttons" hitboxes are not aligned perfectly to the text. (I.E: clicking the space just to the right of "Your Reality" will count as a button click). This is due to the hitboxes resizing to the largest string in the set. Not sure how to adjust this atm.

[therationalpi]

Wow, I really like this menu style. Very nice!

[ThePotatoGuy]

Thanks Pi.

Even though this isn't exactly the same as the Soundtest Interface draft described above, I'm going to create a pull req for the next-release branch. I feel that since this uses a screen object to act as the Music Menu, it would be possible to use this as a base for adding additional features described in the draft.

[therationalpi]

Based on some discussions, the original request might be out of date anyway.

It would be nice if playing a song when you leave this menu could trigger an event where Monika gives her opinion on it, but only if she hasn't before.

[ThePotatoGuy]

That could be done by pushing an event in the select_music function.

This menu could be refined further down the road.

[therationalpi]

I'll go in and try to extend out the menu so the text doesn't overflow the frame. Might need to make a new asset for it or something.