Coder Social home page Coder Social logo

Comments (3)

Mongey avatar Mongey commented on August 20, 2024

Hi! Thanks for the awesome provider!

You're welcome!

It looks like implementing this would be tricky as sarama does not support this yet, am I right?

You're correct, resource-pattern-type was added in v1 of CreateACLRequest, and sarama only supports v0.

It's a pretty small change to the protocol -- I should be able to implement it in sarama and support it in this provider. The only tricky part will be optionally supporting this based on the version of Kafka that's targeted -- as resource-pattern-type only has an effect on Kafka 2.0 and above.

from terraform-provider-kafka.

dmazhar-cogniance avatar dmazhar-cogniance commented on August 20, 2024

Failing if kafka 1.x is used is an option too! :) Another option will be to pass kafka version in the provider 🤔

from terraform-provider-kafka.

Mongey avatar Mongey commented on August 20, 2024

Another option will be to pass kafka version in the provider 🤔

👍 I'll probably go with this

📝 I've started on the sarama changes over @ IBM/sarama#1236. It's a bit more work than expected, as it requires updating Describe & Delete alongside Create.

from terraform-provider-kafka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.