Coder Social home page Coder Social logo

Protobuf Now Mandatory about monero HOT 4 OPEN

vtnerd avatar vtnerd commented on May 27, 2024
Protobuf Now Mandatory

from monero.

Comments (4)

selsta avatar selsta commented on May 27, 2024

Trezor is still optional so the CMake has to be fixed, will take a look at it.

from monero.

vtnerd avatar vtnerd commented on May 27, 2024

I think its just that it defaults to on (looking at a fix myself).

from monero.

vtnerd avatar vtnerd commented on May 27, 2024

@selsta got owned by the CMakeCache again.

This variable defaults to compile Trezor in, which then triggers a requirement for Protobuf. Whereas previously, no explicit opt-out was required.

It seems like this could be flipped to default off, requiring users to opt-in, but we may need to tag the Trezor/Protobuf team on this.

from monero.

selsta avatar selsta commented on May 27, 2024

I think the behaviour should be changed so that if protobuf isn't installed it should print a warning that Trezor compilation is skipped, not fail. Only if USE_DEVICE_TREZOR_MANDATORY is enabled it should fail.

Keeping USE_DEVICE_TREZOR on by default should be fine as long as it doesn't cause the compilation to fail.

from monero.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.