Comments (4)
@molefrog Holy moly that was quick! Happy to hear that you found the answers already 👍 Super excited about this router as this is the first one where I think "yep this is how a router should be done". Love it 💯
from wouter.
Hi @marvinhagemeister!
This is a really nice feedback, I'm a huge fan of ctrl+click myself, but somehow forgot about this scenario 😄
I've got two questions before applying the fix:
- Will this code be supported by React as well? Do I need to have an additional check to cover React?
- What does the
e.button !== 0
check do?
from wouter.
Ok, I jest checked and seems like it's going to be compatible with React, their SyntheticEvent
has all these attributes.
And regarding 2: the check is needed in order to ignore all none-left button clicks. Seems like it should work!
from wouter.
Done!
Fixed in 55fc794 and c54bcf2
from wouter.
Related Issues (20)
- v3.0.0-rc.2 decodeUriComponent is called before route match, breaking links with urlencoded slash (%2F) HOT 2
- v3.0.0-rc.1: `useRoute` should allow `nest` option just like `<Route />` HOT 1
- Suggestion: `<Link>` should always render an `<a>` (or at least have the option to do so) HOT 5
- Accessing nested params with `useParams` HOT 8
- Nested routing broken by intermediate component HOT 2
- Exit animation with framer-motion HOT 7
- How to use V3 with Jest? HOT 3
- [BUG] `useHashLocation` not syncing with state HOT 3
- Docs don't say how to install; no readme on NPM page HOT 1
- import/no-unresolved eslint error being raised on Wouter 3.0.x HOT 3
- Intercept location change with custom hook swallows state HOT 2
- Components being unnecessarily remounted HOT 9
- Link active for all matching sub route HOT 3
- Typescript problem with Route and react-error-boundary
- Is there a way to bypass the `base` of the Router in a Link? HOT 7
- Avoiding race conditions when updating search HOT 6
- build bug HOT 2
- Incorrect matching in paths with wildcards HOT 1
- Uncaught TypeError: Cannot read properties of undefined (reading 'context') HOT 1
- Content of pages inside nesting routes HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wouter.