Coder Social home page Coder Social logo

Comments (9)

skirmess avatar skirmess commented on June 14, 2024 1

Both issues fixed. Thank you!

$ hoarder bookmarks list | grep id: | wc -l
    3892
$ hoarder bookmarks list --list-id mrci6l1iszhqntw1r07pjjc6 | grep id: | wc -l
      10

from hoarder-app.

MohamedBassem avatar MohamedBassem commented on June 14, 2024

Oh, good call. Should be an easy fix. Will fix it over the weekend :) Thanks for the report!

from hoarder-app.

MohamedBassem avatar MohamedBassem commented on June 14, 2024

I pushed CLI version 0.13.0 to address this bug :) Thanks again for the report.

from hoarder-app.

skirmess avatar skirmess commented on June 14, 2024

I've updated the npm version to 0.13.2 (or I think I did, I have this in my package-lock.json)

    "node_modules/@hoarderapp/cli": {
      "version": "0.13.2",

Now it seems to be limited to 100

$ hoarder bookmarks list | grep id: | wc -l
     100

from hoarder-app.

MohamedBassem avatar MohamedBassem commented on June 14, 2024

Do you by any chance have exactly 100 bookmarks? :D

from hoarder-app.

skirmess avatar skirmess commented on June 14, 2024

Unfortunately, no.

Let's create 10 more:

$ for i in 1 2 3 4 5 6 7 8 9 10
> do
>
> hoarder lists add-bookmark --list mrci6l1iszhqntw1r07pjjc6 --bookmark $(hoarder bookmarks add --link https://example.com/test$i | sed -n -e "s/.*id: '//p" | sed -e "s/',//")
> done
Successfully added bookmark from list
Successfully added bookmark from list
Successfully added bookmark from list
Successfully added bookmark from list
Successfully added bookmark from list
Successfully added bookmark from list
Successfully added bookmark from list
Successfully added bookmark from list
Successfully added bookmark from list
Successfully added bookmark from list

Total is still 100:

$ hoarder bookmarks list | grep id: | wc -l
      100

And when I check the new list I don't see any bookmarks.

$ hoarder bookmarks list --list-id mrci6l1iszhqntw1r07pjjc6
[]

With the web interface I can see the 10 links I've created above under https://my-server/dashboard/lists/mrci6l1iszhqntw1r07pjjc6

image

from hoarder-app.

MohamedBassem avatar MohamedBassem commented on June 14, 2024

Interesting ... Let me look into why this is happening. Thanks for taking the time to test it out.

from hoarder-app.

MohamedBassem avatar MohamedBassem commented on June 14, 2024

Turned out, console.log has a default array limit of 100 when printing an object :)

I also found a bug in the way I was doing pagination resulting in some bookmarks created in the same second to be skipped. I'll need to fix that but that will require a server release. Tracking that issue in #140

from hoarder-app.

MohamedBassem avatar MohamedBassem commented on June 14, 2024

The fix should be released in the CLI version 0.13.3.

from hoarder-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.