Coder Social home page Coder Social logo

Comments (4)

vidur2 avatar vidur2 commented on May 24, 2024

Do you have any idea how to run the testing suite? Is the 'Test Examples' workflow comprehensive?

from mojo.

artemiogr97 avatar artemiogr97 commented on May 24, 2024

@JoeLoser there are some differences between StaticTuple and InlineArray so I could not replace it in most of the places:

  • In os._linux_aarch64, os._linux_x86, and os._macos StaticTuple is used for the last unused member of _c_stat which is register_passable and so all members must be register passable, but InlineArray is not register passable (not sure if we can add the decorator)
  • in collections.vector, utils.inlined_string StaticTuple is instantiated with uninitialized values which is forbidden for InlinedArray, maybe a staticmethod undefined_init could be created for those cases? I think keeping the init that causes a compile time error makes sense, should we allow to create an uninitialized array somehow something like __init__(*, uninitialized: Bool) such that it can not easily be created by accident
  • the other uses are either in StaticIntTuple or in the tests, so to be removed at the end once they are no longer used

from mojo.

ConnorGray avatar ConnorGray commented on May 24, 2024

Hi @artemiogr97, re. your second question:

in collections.vector, utils.inlined_string StaticTuple is instantiated with uninitialized values which is forbidden for InlinedArray

Yes, it would be good for us to preserve a way to create uninitialized InlinedArray values.

We may want to go a different direction down the line, but I think your suggestion for a __init__(*, uninitialized: Bool) seems like a reasonable solution to try for the time beingπŸ™‚

from mojo.

JoeLoser avatar JoeLoser commented on May 24, 2024

Fixed with 6af1fa7. Thank you!

from mojo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.