Coder Social home page Coder Social logo

Comments (4)

malbolger avatar malbolger commented on May 14, 2024 1

Two quick changes should fix this and stop the attribute settings from the [props menu.

In Item.cs inside the "public double Weight" (around line 496) You need to change:

if (info.m_Weight == -1)

to:

if (info.m_Weight <= -1)

and also in Item.cs inside the "VerifyCompactInfo()" (around line 1724) You need to change:

|| info.m_Weight != -1;

to:

|| info.m_Weight > -1;

from modernuo.

kamronbatman avatar kamronbatman commented on May 14, 2024

Is negative weight an ACTUAL thing? Should we treat any negative value as something special and default to weight of 0?

What happens on actual UO servers?

from modernuo.

Krubster avatar Krubster commented on May 14, 2024

I've never seen such functionality on offical servers and negative weight sounds weird. This feature can be done with overriding TotalWeight property

from modernuo.

kamronbatman avatar kamronbatman commented on May 14, 2024

So I will keep this as a bug, and we should default any negative number to 0. Overriding that can be done on a per item basis by overriding the weight functions I assume.

This is up for grabs for anyone that wants to fix it. :)

Edit: is weight an int or uint to the client? Let's find out.

from modernuo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.