Comments (4)
Two quick changes should fix this and stop the attribute settings from the [props menu.
In Item.cs inside the "public double Weight" (around line 496) You need to change:
if (info.m_Weight == -1)
to:
if (info.m_Weight <= -1)
and also in Item.cs inside the "VerifyCompactInfo()" (around line 1724) You need to change:
|| info.m_Weight != -1;
to:
|| info.m_Weight > -1;
from modernuo.
Is negative weight an ACTUAL thing? Should we treat any negative value as something special and default to weight of 0?
What happens on actual UO servers?
from modernuo.
I've never seen such functionality on offical servers and negative weight sounds weird. This feature can be done with overriding TotalWeight property
from modernuo.
So I will keep this as a bug, and we should default any negative number to 0. Overriding that can be done on a per item basis by overriding the weight functions I assume.
This is up for grabs for anyone that wants to fix it. :)
Edit: is weight an int or uint to the client? Let's find out.
from modernuo.
Related Issues (20)
- [BUG] GeneretionFaction
- [Bug] Factions System
- Potential issue with TimeSpan factory methods
- .Net 8 - SendOPLPacketTo sends corrupt data
- Add New Magincia to starting cities for the clients/eras that support it.
- Make Tracking Skill closer to OSI
- Gump refactor for caching and functional generation HOT 6
- [BUG] Feint weapon ability is implemented incorrectly
- Remove IPAddress Intern
- Remove duplicate commands from HelpInfo
- Upgrade Ethics system to use Codegen
- Break up large codegenned files to improve IDE performance
- BloodOath timing is inaccurate
- Boats run into each other causes stuck entities
- Placing Houses next to each other causes z level issues
- Fix seeding/UOG HOT 1
- Make Travel Restrictions configurable
- New loot system HOT 1
- Update TextDefinition to support new Gump API
- Libdeflate as drop-in replacement for Zlib compression HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modernuo.