README.md suggestion about modernuo

[kamronbatman]

Ohhh I like this, where you actually go from publish.cmd -> publish.sh so that way you get the shebang.

Do you want to make a PR for this, or should I?

[kamronbatman]

I think this is still valid since zsh throws errors with publish.cmd directly. Workaround is to use publish.sh, or maybe someone can help update publish.cmd to be more broadly usable.

[nerun]

Ok, errors with CMD file:

$ ./publish.cmd release linux x64
./publish.cmd: 10: [[: not found
./publish.cmd: 12: [[: not found
./publish.cmd: 19: Syntax error: redirection unexpected

There should be an issue with if [[ ... ]], maybe if [ ... ] should be used. To be POSIX compliant, change:

if [[ -n $os ]]; then
  os="-r $os"
elif [[ $(uname) = "Darwin" ]]; then
  os="-r osx"

To:

if [ -n $os ]; then
  os="-r $os"
elif [ $(uname) = "Darwin" ]; then
  os="-r osx"

Or to:

if [ -n $os ]; then
  os="-r $os"
elif [[ $(uname) == "Darwin" ]]; then
  os="-r osx"

The last one:

config="$(tr '[:lower:]' '[:upper:]' <<< ${1:0:1})${1:1}"

I don't know what it is supposed to do, but i can't see the end of the command $(command here). Don't know what to do here.

But with the two fixes above:

$ ./publish.cmd release linux x64
./publish.cmd: 19: Syntax error: redirection unexpected

And it still works with publish.sh. Check if it works on Windows.

[nerun]

Uh ok, i got it: Stack Overflow - uppercase first character in a variable with bash

config="$(tr '[:lower:]' '[:upper:]' <<< ${1:0:1})${1:1}" is to uppercase 1st letter

[nerun]

One way is to move the entire ::SHELLSCRIPT (up to exit $? inclusive) to publish.sh. It worked for me, i run publish.cmd successfully in ZSH / Linux Mint.

publish.cmd

:<<"::SHELLSCRIPT"
@ECHO OFF
GOTO :CMDSCRIPT

::SHELLSCRIPT
path=$(dirname "$0")
cd $path
./publish.sh
exit 1

:CMDSCRIPT

IF "%~1" == "" (
  SET config=-c Release
) ELSE (
  IF "%~1" == "release" (
    SET config=-c Release
  ) ELSE (
    SET config=-c Debug
  )
)

IF "%~2" == "" (
  SET os=-r win
) ELSE (
  SET os=-r %~2
)

IF "%~3" == "" (
  SET arch=x64
) ELSE (
  SET arch=%~3
)

echo dotnet tool restore
dotnet tool restore

echo dotnet clean --verbosity quiet
dotnet clean --verbosity quiet
echo dotnet restore --force-evaluate --source https://api.nuget.org/v3/index.json
dotnet restore --force-evaluate --source https://api.nuget.org/v3/index.json

echo dotnet publish %config% %os%-%arch% --no-restore --self-contained=false -o Distribution\Assemblies Projects\UOContent\UOContent.csproj
dotnet publish %config% %os%-%arch% --no-restore --self-contained=false -o Distribution\Assemblies Projects\UOContent\UOContent.csproj

echo Generating serialization migration schema...
dotnet tool run ModernUOSchemaGenerator -- ModernUO.sln

publish.sh

#!/bin/bash
config=$1
os=$2
arch=${3:-$(uname -m)}

if [[ -n $os ]]; then
  os="-r $os"
elif [[ $(uname) = "Darwin" ]]; then
  os="-r osx"
else
  os="-r linux"
fi

if [[ $config ]]; then
  config="$(tr '[:lower:]' '[:upper:]' <<< ${1:0:1})${1:1}"
  config="-c $config"
else
  config="-c Release"
fi

if [[ $arch == *'aarch'* || $arch == *'arm'* ]]; then
  arch="arm64"
else
  arch="x64"
fi

if [[ $os == *'centos'* || $os == *'rhel'* ]]; then
  export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1
fi

echo dotnet tool restore
dotnet tool restore

echo dotnet clean --verbosity quiet
dotnet clean --verbosity quiet
echo dotnet restore --force-evaluate --source https://api.nuget.org/v3/index.json
dotnet restore --force-evaluate --source https://api.nuget.org/v3/index.json

echo dotnet publish ${config} ${os}-${arch} --no-restore --self-contained=false -o Distribution/Assemblies Projects/UOContent/UOContent.csproj
dotnet publish ${config} ${os}-${arch} --no-restore --self-contained=false -o Distribution/Assemblies Projects/UOContent/UOContent.csproj

echo Generating serialization migration schema...
dotnet tool run ModernUOSchemaGenerator -- ModernUO.sln

exit $?

[nerun]

Yes, i dit it.

ERRATA

In publish.cmd, this:

::SHELLSCRIPT
./publish.sh
exit 1

Would be better to be:

::SHELLSCRIPT
path=$(dirname "$0")
cd $path
./publish.sh
exit 1

Just in case you call publish.cmd from another directory.