Coder Social home page Coder Social logo

Comments (4)

jowr avatar jowr commented on July 24, 2024

I guess this one is obsolete soon since #6 already contains my changes that introduced CMake. However, my code was written in a hurry and I would appreciate if you had a look at it.

from externalmedia.

slamer59 avatar slamer59 commented on July 24, 2024

It is a good starting point to reach the objective by the end of the year.

For an enhancement, all commands in .bat file and .sh in ExternalMedia/Projects/ may be integrated in CMakeLists.txt. It will be easier to maintain one file for cmake than 10 specific files for specific compilation.

We can build a more robust cross compilation process integrating all those command in CMake:

  • FindGit.cmake helps to find git and will replace all commands like git clone, git pull,...
  • CFLAGS will replace for example C_OPTS, i.e. GCC_OPTS, variable in .bat file, .i.e .sh file
  • file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/ DESTINATION ${CMAKE_CURRENT_BINARY_DIR}) to replace copy or cp command
  • ...

I guess all specific compilation option will be handle by hand or by TravisCI system.

from externalmedia.

jowr avatar jowr commented on July 24, 2024

Yes, but we still have to decide whether we want to use CoolProp as a submodule in git or as an external CMake project (ExternalProject_Add). I think we should try to avoid calling git manually :-)

from externalmedia.

slamer59 avatar slamer59 commented on July 24, 2024

@jowr, I think this is not related to CMake
So I open a specific subject #8

from externalmedia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.