Comments (11)
As @casella referred me, please have a look at #27; at least Test.CoolProp.CO2.TestBasePropertiesImplicit
would work on this modification, particularly, of setSate_ph. In addition, there is an attempt to build a DLL linking SimualtionRuntimeC
and omcgc
, which enables ModelicaError
; however, I'm not sure whether it is safe. What's about that?
from externalmedia.
OK - here is the current status:
- Test.CoolProp.CO2.TestStatesSupercritical runs
- Test.CoolProp.CO2.TestStatesTranscritical runs
- Test.CoolProp.CO2.TestStatesSatSubcritical fails
- Test.CoolProp.CO2.TestBasePropertiesExplicit runs
- Test.CoolProp.CO2.TestBasePropertiesImplicit runs (with Modelica error messages)
- Test.CoolProp.CO2.TestBasePropertiesDynamic runs
- Test.CoolProp.CO2.TestBasePropertiesTranscritical runs
@casella, is this what you wanted to see? Can we close this issue?
from externalmedia.
Hmm.. you (@jowr) said that "Test.CoolProp.CO2.TestStatesSatSubcritical fails".
Isn't "fails" a typo? Otherwise, what kind of issue does it have?
I just find that it works without a trouble.. So, I'm just curious..
from externalmedia.
Hm - it was not a typo:
Do you use the same old version of CoolProp or are you running your updated code?
from externalmedia.
Uh-oh.. It's the version 6 (the latest one) with my update for REFPROP backend; the other part is the same.
And, it is running in OpenModelica.
from externalmedia.
One more thing! The ExternalMedia library is also my updated one in PR #27. FYI!
from externalmedia.
* Test.CoolProp.CO2.TestBasePropertiesImplicit runs (with Modelica error messages)
This is ok, I understand the implicit solver makes some attempts that call the property calculations outside their range, so if this is now handled correctly via calls to ModelicaError, that's the intended behaviour.
from externalmedia.
This is a bit weird, I don't understand who is issuing this error message T is not a valid number
, the string "is not a valid number" cannot be found in the Modelica and C source files.
@jowr, is this a known error message of CoolProp?
Then, there could be some issue with the solver that passes an invalid value to the CoolProp solver in the temperature field, e.g., NaN. No idea why, but we can investigate.
Could this be related to #34 in some way?
from externalmedia.
@jowr, in any case, any such remaining issue is beyond the scope of this ticket. Please let me check with the CI binaries as soon as they're available, then I'll close this myself.
from externalmedia.
@casella did you check with the CI binaries? Can we close this issue?
from externalmedia.
OK - I consider this closed. Should we release v3.3.0?
from externalmedia.
Related Issues (20)
- Incompressible package runs in OpenModelica but not Dymola
- Model fails to execute when using two different fluids
- Model fails to run when using Modelica.Fluid.Sensors.Temperature
- Call ExternalMedia from OMPython HOT 1
- External function could not be found in any of the given shared libraries HOT 1
- External functions in ExternalMedia should be explicitly declared as pure
- Use CoolProp 6.4.4 as soon as it is released, instead of nightly build HOT 1
- support for older gcc versions HOT 4
- Compilation errors in OpenModelica HOT 7
- Selection of different state variables (ph, pt, dT) for a CoolProp 2-phase medium HOT 1
- Cannot compute arbitrary partial derivatives with function `partialDeriv_state` HOT 2
- Wrong version of cmake required to compile the library HOT 1
- Restructuring of the repository HOT 4
- build error using cmake on windows HOT 1
- State functions do not seem to work properly HOT 6
- Compressible mixture support? HOT 2
- Custom fluid property support
- Incompressible CoolProp tests do not compile HOT 3
- Remove experiment annotation from partial models
- how to use fliudprop in external Media?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from externalmedia.