Some tests fail at runtime with v.3.3.0 due to wrong error management about externalmedia

[dongkeun-oh]

As @casella referred me, please have a look at #27; at least Test.CoolProp.CO2.TestBasePropertiesImplicit would work on this modification, particularly, of setSate_ph. In addition, there is an attempt to build a DLL linking SimualtionRuntimeC and omcgc, which enables ModelicaError; however, I'm not sure whether it is safe. What's about that?

[jowr]

OK - here is the current status:

• Test.CoolProp.CO2.TestStatesSupercritical runs
• Test.CoolProp.CO2.TestStatesTranscritical runs
• Test.CoolProp.CO2.TestStatesSatSubcritical fails
• Test.CoolProp.CO2.TestBasePropertiesExplicit runs
• Test.CoolProp.CO2.TestBasePropertiesImplicit runs (with Modelica error messages)
• Test.CoolProp.CO2.TestBasePropertiesDynamic runs
• Test.CoolProp.CO2.TestBasePropertiesTranscritical runs

@casella, is this what you wanted to see? Can we close this issue?

[dongkeun-oh]

Hmm.. you (@jowr) said that "Test.CoolProp.CO2.TestStatesSatSubcritical fails".
Isn't "fails" a typo? Otherwise, what kind of issue does it have?
I just find that it works without a trouble.. So, I'm just curious..

[jowr]

Hm - it was not a typo:

Do you use the same old version of CoolProp or are you running your updated code?

[dongkeun-oh]

Uh-oh.. It's the version 6 (the latest one) with my update for REFPROP backend; the other part is the same.
And, it is running in OpenModelica.

[dongkeun-oh]

One more thing! The ExternalMedia library is also my updated one in PR #27. FYI!

[casella]

* Test.CoolProp.CO2.TestBasePropertiesImplicit runs (with Modelica error messages)

This is ok, I understand the implicit solver makes some attempts that call the property calculations outside their range, so if this is now handled correctly via calls to ModelicaError, that's the intended behaviour.

[casella]

This is a bit weird, I don't understand who is issuing this error message T is not a valid number, the string "is not a valid number" cannot be found in the Modelica and C source files.

@jowr, is this a known error message of CoolProp?

Then, there could be some issue with the solver that passes an invalid value to the CoolProp solver in the temperature field, e.g., NaN. No idea why, but we can investigate.

Could this be related to #34 in some way?

[casella]

@jowr, in any case, any such remaining issue is beyond the scope of this ticket. Please let me check with the CI binaries as soon as they're available, then I'll close this myself.

[jowr]

@casella did you check with the CI binaries? Can we close this issue?

[jowr]

OK - I consider this closed. Should we release v3.3.0?