Comments (4)
I think it can be done without any pom.xml template - it will be hard to keep template and pom.xml in sync. I will look more deeply on it in April.
from shipkit.
I've created initial pom plugin. Added a TODO to the code with some examples how to approach the problem :)
from shipkit.
Design question
I fought about how to solve this problem. GitHubContributorsProvider.mapContributorsToGitHubUser(...)
always ask only for contributors between two commits (usually last released version and HEAD). My first idea was to call this method inside PomCustomizer.customizePom(...)
, but then only last contributors will be added to the pom.xml (and hardcoded in gradle/release.gradle
).
In my opinion it's better to update in some previous step (before generatePomFileForJavaLibraryPublication
) a property ext.pom_contributors
in gradle/release.gradle
and add new contributors to the list. Then we need to adjust logic in PomCustomizer.customizePom(...)
a little bit (to handle more info about contributors) and continous-delivery-drone will commit this file together with release-notes. In this approach we reduce a number of requests to github.com, speed up a build and are sure that we don't skip anybody in pom.
@szczepiq WDYT?
from shipkit.
Let's optimize for:
- least amount of requests to GitHub
- minimum overhead to the build time
We have a couple of options:
- we just maintain the mapping in a file, it would be manually maintained
- we add a discrete step (task) that gets the data before we update pom (this is what you're suggesting, right?)
- do some smart caching if possible, commits pushed to main dev branches don't change :)
I've started to use latest version of mockito release tools in mockito and noticed that the generation of notable release notes adds overhead due to getting the user mappings for each notable version. For the time being I'll simplify it and avoid requesting user mappings for notable release notes. They don't need it because the notable notes don't have authors (for now, we can change it if we see fit).
Thank you for working on this!!!
from shipkit.
Related Issues (20)
- javadoc and java plugins are applied in the wrong order HOT 1
- Disabling Release Notes Generation HOT 3
- Unicode in user name of commit HOT 1
- Instructions/compatibility with GitHub Actions HOT 2
- Release to GH and add generated files to release HOT 8
- POM exception when using shipkit with jar archiveClassifier HOT 2
- deprecation warning: The baseName property has been deprecated HOT 3
- BintrayDefaultArtifactUrlResolver does not URL encode slashes in file_path HOT 1
- Adding an archive from a subproject's task causes a build failure HOT 10
- Support for building a project multiple times (multiple artifacts) and publishing as one version HOT 13
- Default POM generated by Shipkit does not meet Maven Central requirements HOT 2
- github access_token query parameter deprecated, breaks after 2020/07/01 HOT 6
- -PskipComparePublications=true doesn't work with ./gradlew -PskipComparePublications=true
- Question: GitHub release provider for Travis needed? HOT 1
- Release normal jar and fat jar at the same time HOT 7
- Shipkit for Scala multi-variant project HOT 4
- Build fails due to upgrade downstream failure on code coverage check
- GradlePortalReleasePlugin: Cannot add task 'validatePlugins' as a task with that name already exists
- Include LICENSE to META-INF rather that to the root of the archives HOT 2
- Will shipkit automatically tag and push to bintray after setup? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shipkit.