Coder Social home page Coder Social logo

Comments (4)

mstachniuk avatar mstachniuk commented on May 31, 2024

I think it can be done without any pom.xml template - it will be hard to keep template and pom.xml in sync. I will look more deeply on it in April.

from shipkit.

mockitoguy avatar mockitoguy commented on May 31, 2024

I've created initial pom plugin. Added a TODO to the code with some examples how to approach the problem :)

from shipkit.

mstachniuk avatar mstachniuk commented on May 31, 2024

Design question
I fought about how to solve this problem. GitHubContributorsProvider.mapContributorsToGitHubUser(...) always ask only for contributors between two commits (usually last released version and HEAD). My first idea was to call this method inside PomCustomizer.customizePom(...), but then only last contributors will be added to the pom.xml (and hardcoded in gradle/release.gradle).

In my opinion it's better to update in some previous step (before generatePomFileForJavaLibraryPublication) a property ext.pom_contributors in gradle/release.gradle and add new contributors to the list. Then we need to adjust logic in PomCustomizer.customizePom(...) a little bit (to handle more info about contributors) and continous-delivery-drone will commit this file together with release-notes. In this approach we reduce a number of requests to github.com, speed up a build and are sure that we don't skip anybody in pom.

@szczepiq WDYT?

from shipkit.

mockitoguy avatar mockitoguy commented on May 31, 2024

Let's optimize for:

  • least amount of requests to GitHub
  • minimum overhead to the build time

We have a couple of options:

  • we just maintain the mapping in a file, it would be manually maintained
  • we add a discrete step (task) that gets the data before we update pom (this is what you're suggesting, right?)
  • do some smart caching if possible, commits pushed to main dev branches don't change :)

I've started to use latest version of mockito release tools in mockito and noticed that the generation of notable release notes adds overhead due to getting the user mappings for each notable version. For the time being I'll simplify it and avoid requesting user mappings for notable release notes. They don't need it because the notable notes don't have authors (for now, we can change it if we see fit).

Thank you for working on this!!!

from shipkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.