Comments (6)
Perhaps you could provide a PR to test if the wrong property is provided and output an error message informing users?
And another PR that fixes the inconsistency with mockserver-client-node
?
from mockserver-node.
Yes, I could give it a try on monday.
I assume that you want to go with jvmOptions instead of systemProperties then?
P.S. I already made an unrelated PR for mockserver-client-node in the meantime.
from mockserver-node.
Thanks I have merged all your PRs, and yes I think jvmOptions is clearer for a none JVM audience, because systemProperties is very JVM specific.
I may be able to find time add a check for use of the previous value to alert people to the breaking change, or a PR would be welcomed.
from mockserver-node.
Yep, thanks for merging my PRs!
I PR for the this issue is already in the making but #12 got into my way while writing a test.
So if you could fix #12 I will send a PR for #10 soon.
from mockserver-node.
Hi @jamesdbloom , as #12 is fixed by now I opened an PR on this issue.
from mockserver-node.
@jamesdbloom any chance to see this merged within the next days?
Thanks in advance!
from mockserver-node.
Related Issues (20)
- buildkite links not accessable HOT 2
- download_jar fails at following redirect HOT 3
- Error when developing with nodemon HOT 1
- No option to specify log path HOT 1
- Disable downloadJar logs if trace or verbose are setted to false HOT 3
- Adding extra headers to requests forwarding with httpForward HOT 2
- security issues when using opensource certificate HOT 3
- Multiple jvmOptions not possible HOT 3
- httpForward doesn't work HOT 1
- Glob is too hungry / very slow HOT 1
- `SIGINT` handler overrides default behaviour HOT 3
- Make grunt task `stop_mockserver` synchronous for every port HOT 2
- Unable to add a callback after reset HOT 1
- Getting warnings of An illegal reflective access operation has occurred HOT 1
- Could not find or load main class DELETE (`ClassNotFoundException`) HOT 1
- `SIGTERM` handler overrides default behaviour
- Types for mockserver-node module HOT 1
- Update mockserver jar to 5.4.1
- index.d.ts file is not included in package published on the npm registry HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mockserver-node.