Coder Social home page Coder Social logo

Comments (6)

jamesdbloom avatar jamesdbloom commented on June 14, 2024

Perhaps you could provide a PR to test if the wrong property is provided and output an error message informing users?

And another PR that fixes the inconsistency with mockserver-client-node?

from mockserver-node.

hennr avatar hennr commented on June 14, 2024

Yes, I could give it a try on monday.
I assume that you want to go with jvmOptions instead of systemProperties then?

P.S. I already made an unrelated PR for mockserver-client-node in the meantime.

from mockserver-node.

jamesdbloom avatar jamesdbloom commented on June 14, 2024

Thanks I have merged all your PRs, and yes I think jvmOptions is clearer for a none JVM audience, because systemProperties is very JVM specific.

I may be able to find time add a check for use of the previous value to alert people to the breaking change, or a PR would be welcomed.

from mockserver-node.

hennr avatar hennr commented on June 14, 2024

Yep, thanks for merging my PRs!

I PR for the this issue is already in the making but #12 got into my way while writing a test.
So if you could fix #12 I will send a PR for #10 soon.

from mockserver-node.

hennr avatar hennr commented on June 14, 2024

Hi @jamesdbloom , as #12 is fixed by now I opened an PR on this issue.

from mockserver-node.

hennr avatar hennr commented on June 14, 2024

@jamesdbloom any chance to see this merged within the next days?
Thanks in advance!

from mockserver-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.