Add Test Coverage about store

[digitalbuddha]

@ychescale9 sure! We use truth internally. I'll make a different issue for tracking

[burakeregar]

In the meantime, I will be starting to implement Jacoco. Then we can jump onto the second part when the internal process is done.

Now that we are getting external contributions, I think it would be beneficial to have some sort of code coverage report in the prs. @changusmc & @wclausen do you have any thoughts on what we should use?

There's two parts to this. (1) Generate the coverage data, for Java and Kotlin, we'd likely have to use Jacoco. I don't know of any other tools that get coverage for Java/Kotlin. (2) Surface the coverage data and enforce coverage on new PRs, some popular tools for this is Coveralls, Codecov, Codacy, all free for open source, but we'll have to get dev-infra to install it for the Dropbox org. That would probably require a software request internally.

[changusmc]

If you can get the merged coverage.xml and coverage.ec, that would be great and can support any solution we move forward with. Thanks!

…

On Mon, Dec 16, 2019 at 12:58 PM Burak Eregar ***@***.***> wrote: In the meantime, I will be starting to implement Jacoco. Then we can jump onto the second part when the internal process is done. Now that we are getting external contributions, I think it would be beneficial to have some sort of code coverage report in the prs. @changusmc <https://github.com/changusmc> & @wclausen <https://github.com/wclausen> do you have any thoughts on what we should use? There's two parts to this. (1) Generate the coverage data, for Java and Kotlin, we'd likely have to use Jacoco. I don't know of any other tools that get coverage for Java/Kotlin. (2) Surface the coverage data and enforce coverage on new PRs, some popular tools for this is Coveralls, Codecov, Codacy, all free for open source, but we'll have to get dev-infra to install it for the Dropbox org. That would probably require a software request internally. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCPWM33JFH77OK7UVFISUTQY7TWLANCNFSM4JZHLGZQ> .

[ychescale9]

Would you also be open to migrating to a more modern assertion library like truth or kluent?

[changusmc]

Now that we are getting external contributions, I think it would be beneficial to have some sort of code coverage report in the prs. @changusmc & @wclausen do you have any thoughts on what we should use?

There's two parts to this. (1) Generate the coverage data, for Java and Kotlin, we'd likely have to use Jacoco. I don't know of any other tools that get coverage for Java/Kotlin. (2) Surface the coverage data and enforce coverage on new PRs, some popular tools for this is Coveralls, Codecov, Codacy, all free for open source, but we'll have to get dev-infra to install it for the Dropbox org. That would probably require a software request internally.

[wclausen]

some popular tools for this is Coveralls, Codecov, Codacy, all free for open source, but we'll have to get dev-infra to install it for the Dropbox org. That would probably require a software request internally.

I have no strong preference among those. They all seem good/easy to use. I'd go with codecov as their browser extension that shows what lines are covered vs not seems pretty nifty.

[digitalbuddha]

Reached out to infra. Let's see what we have available internally