Coder Social home page Coder Social logo

Comments (5)

ychescale9 avatar ychescale9 commented on May 29, 2024 1

Thanks!

from store.

ychescale9 avatar ychescale9 commented on May 29, 2024

@digitalbuddha I can have a go at this. Could you elaborate on the second requirement? Would this involve changing current APIs?

from store.

digitalbuddha avatar digitalbuddha commented on May 29, 2024

No changes from current api. Here is the current builder, we would need the same in the new impl: https://github.com/dropbox/Store/blob/1810355341a9d6f2f8dc17e117d3dec31b10407b/store/src/main/java/com/dropbox/android/external/store4/impl/RealStore.kt#L58

Here is the current interface for usage:
https://github.com/dropbox/Store/blob/1810355341a9d6f2f8dc17e117d3dec31b10407b/cache/src/main/java/com/dropbox/android/external/cache3/Cache.java#L12

We do not need to support the blocking get call which calls a loader. That was an api that store3 had that is no longer needed.

@Nonnull
  V get(K key, Callable<? extends V> valueLoader) throws ExecutionException;

Appreciate the help but as a warning we would expect 100% test coverage before accepting the contribution. Current implementation does not have many tests in repo due it being taken from Guava which had extensive testing

from store.

ychescale9 avatar ychescale9 commented on May 29, 2024

We do not need to support the blocking get call which calls a loader. That was an api that store3 had that is no longer needed.

@Nonnull
  V get(K key, Callable<? extends V> valueLoader) throws ExecutionException;

@digitalbuddha So looks like we do need to support this after all? Currently this is only used by FileSystemImpl. Are we planning to use this API anywhere else or even expose it in the Store API?

from store.

yigit avatar yigit commented on May 29, 2024

for xref: #89

from store.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.