Comments (4)
hey, I look at your readme and your plugin demands the user to use the app secret in ios and android.
This is very bad practise as soon as an attacker gets the apk and decompile the code and he also gets the app secret.
You should never use code flow out side a server only code flow + pkce is a proper options.
Are you aware of that?
Update: Maybe Twitterkit manages the secure holding of the appSecret but it seems odd though.
from capacitor-oauth2.
I think your PR would be better suited for https://github.com/ionic-team/capacitor/blob/master/site/docs-md/community/plugins.md#authentication.
There are already a couple of authentication plugins on that list and I don't want to curate a list myself because Capacitor already has one.
from capacitor-oauth2.
It makes no sense, that's the way twitterkit handles it.
Ok no problem. PR was already submitted to the docs.
from capacitor-oauth2.
TwitterKit forcing you to do so, does not mean that it is generally a good idea.
Of course you don't have to believe me but please search the web and look for resources which do recommend the usage of code flow and the appSecret in public native apps.
from capacitor-oauth2.
Related Issues (20)
- Feat: Capacitor 4 support
- Help: Code grant type not working with spring OAuth server HOT 1
- Popup blocked in Safari for pkce flow HOT 1
- Navigation is Unreachable HOT 1
- Bug: Error: ERR_GENERAL (1000 - invalid request - duplicated parameter) HOT 1
- How to use windowTarget: "_self" HOT 2
- Problem opening native authenticator app HOT 1
- How to get Refresh Token with windowTarget: "_self". HOT 3
- Call back function is not returning the value
- ERR_STATES_NOT_MATCH
- HELP: Getting "USER_CANCELLED" error with Google oAuth2 in Android Simulator HOT 1
- Tweaks for using with Spotify OAuth HOT 2
- Feat: Integration with trapeze to improve configuration
- Auth0 HOT 1
- Bug: Intent filter not working for redirection after login HOT 2
- Feat: Support Android 13 HOT 2
- Support for Capacitor 5 HOT 10
- Is there a way to get a login prompt? HOT 1
- Azure B2C ui_locales is directly supported via the auth request builder exception HOT 2
- I am not able to hide URL bar HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from capacitor-oauth2.