Comments (4)
I've discovered a bug in the tileview which is related (but possibly not the cause of) the following issue.
On this line https://github.com/moagrius/TileView/blob/master/src/com/qozix/tileview/TileView.java#L459
you'll see that the tileview calls up to markerManager.removeView when it should be calling up to markerManager.removeMarker - by removing the view the markerManager's internal markerMap is never updated with the markers which are being removed from the view.
from tileview.
Fixing the above bug fixes only half of the problem I'm having, the second part of the problem is that the view rect is not correctly set for the view by the time the marker is tapped, I've created a really horrific hack which works for now but isn't ideal. I'm not entirely certain why the call to onLayout isn't updating the rect correctly but I will keep digging until I find the right way to resolve this.
from tileview.
Very good to know (and good catch by you) to find the removeView/marker mistake - I'll correct that right away.
For the second issue, you might try removing the onChanged test - that was a late add and should work in theory but I really didn't test it explicitly - I assumed the changed boolean params is being correctly passed by the system.
Also, you are free to use standard View listeners (e.g., View.OnClickListener) rather than the MarkerEventListener interface - I'm not sure if that's appropriate for your app, but it's certainly a more familiar set of functionality.
from tileview.
Fixed and committed.
from tileview.
Related Issues (20)
- Issues scaling past 1f HOT 3
- Remote tile demo freezes and crashes HOT 2
- Combine smooth scroll and scale HOT 2
- Tiles not properly laid out when Scale < 1 with remote tiles HOT 15
- Open source but no license? HOT 2
- Markers disappear when zooming HOT 4
- Cannot add tile images on the fly HOT 1
- StreamProvider asked to provide data for rows and columns out of bounds with to small images HOT 5
- Tiles outside the image are created HOT 8
- White text on white background in Advanved Tile Demo HOT 1
- Get touched position when touch on the tileview (version 4.0.7)
- longtouch
- App killed in background crashes when returning to foreground HOT 1
- `android.os.BadParcelableException` regarding `com.moagrius.widget.ScrollView$SavedState.<init>` HOT 1
- Use in viewholder for recycler view. HOT 2
- build() method starts to return void instead of TileView HOT 1
- Mike passed away HOT 5
- Does this lib support SVG format
- JCenter -> MavenCenter
- implementation 'com.qozix:tileview:2.7.7' doesn't seem to work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tileview.