Coder Social home page Coder Social logo

Comments (4)

klattimer avatar klattimer commented on July 23, 2024

I've discovered a bug in the tileview which is related (but possibly not the cause of) the following issue.

On this line https://github.com/moagrius/TileView/blob/master/src/com/qozix/tileview/TileView.java#L459

you'll see that the tileview calls up to markerManager.removeView when it should be calling up to markerManager.removeMarker - by removing the view the markerManager's internal markerMap is never updated with the markers which are being removed from the view.

from tileview.

klattimer avatar klattimer commented on July 23, 2024

Fixing the above bug fixes only half of the problem I'm having, the second part of the problem is that the view rect is not correctly set for the view by the time the marker is tapped, I've created a really horrific hack which works for now but isn't ideal. I'm not entirely certain why the call to onLayout isn't updating the rect correctly but I will keep digging until I find the right way to resolve this.

from tileview.

moagrius avatar moagrius commented on July 23, 2024

Very good to know (and good catch by you) to find the removeView/marker mistake - I'll correct that right away.

For the second issue, you might try removing the onChanged test - that was a late add and should work in theory but I really didn't test it explicitly - I assumed the changed boolean params is being correctly passed by the system.

Also, you are free to use standard View listeners (e.g., View.OnClickListener) rather than the MarkerEventListener interface - I'm not sure if that's appropriate for your app, but it's certainly a more familiar set of functionality.

from tileview.

moagrius avatar moagrius commented on July 23, 2024

Fixed and committed.

from tileview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.