Marker Tap event not triggered after dynamic add about tileview

[moagrius]

i'm not following - can you use code or psuedo-code to describe step-by-step what you're experiencing?

[moagrius]

per email exchange, this issue was resolved by calling requestLayout after adding a marker, to make sure the layout rect was registered with the hit-testing map. The latest release has this functionality built-in.

[Eteokles]

For me it's not working. When i add a marker dynamically and if i don't zoom in or out onTap is not triggered. I use the last src version and i've called requestLayout (after a test without) but it doesn't work...

[Tristus1er]

Same here !

[moagrius]

can you guys try calling both invalidate* and postInvalidate on the MarkerManager after the marker is added?

or... can you provide step-by-step instructions to recreate?

[Eteokles]

in my onFingerDown method i do
handler.postdelayed( runnable, ViewConfiguration.getLongPressTimeout() );

runnable :
public void run() {
if (!movedFinger) {
ImageView marker = new ImageView(ctx);
marker.setImageResource(R.drawable.marker);
marker.setTag("Test");
tileview.addMarker(marker, xPoint, yPoint, -0.5f, -1f);
}
}

I've tried both invalidate and postInvalidate but without result.

[moagrius]

I see - so the marker is rendering but it's not being registered for the onMarkerTap event, right? If that's not correct, please explain.

Assuming that is correct, a little background: onMakerTap just compares the coordinates of the tap event to a map of all the marker's layout as Rects. This is calculated in onLayout.

I suspect the problem is because you're both adding markers from a handler, off the UI thread. So, try this:

At the end of your run method (on the line after tileview.addMarker(marker, xPoint, yPoint, -0.5f, -1f);), add something like this

tileview.post(new Runnable(){
  @Override
  public void run(){
    tileview.requestLayout();
  }
});

post will be called on the TileView's UI thread, and hopefully force a recalculation of the marker layouts which would register them with the onMarkerTap map of Rects.

LMK if that helps. If not, I'll try to recreate locally to find a patch.

[Eteokles]

nop... it still not work.

[moagrius]

ok, i'll create a debug build and post back within the next couple days, hopefully with a patch to commit

thanks for the feedback

[Eteokles]

in the onLayout method of MarkerManager if i comment

if(!changed){ 
    return; 
}

It's work. The Rect is not define.

[moagrius]

awesome - looks like a premature optimization - I'll make the change and commit as soon as I get a chance.

thanks!

[moagrius]

@skaor this patch has been included in the latest commit and release. thanks for contributing!

[Eteokles]

yeahhh my first contrib to a github project :p !

[moagrius]

you're even mentioned in the release - you're basically famous now ;)