Add option to import BrainVision files without marker types about mne-python

[drammock]

You mean to ignore only specific types, e.g. ignore_marker_types=["Comment", "Stimulus"]? I'm not sure how often this is needed

Seems to me like there's clear motivation for "ignore marker types when they're all identical" and uncertain motivation for "let me specify which one(s) to ignore". I'd suggest to assume YAGNI on the second one, and we can overload the param later (to accept list-likes) if folks ask for it.

I'd also consider something like an "always/auto/never" pattern, where "auto" means "ignore them IFF they're all identical". But a simple boolean seems adequate for now --- again, we can update the param later to give more flexibility if folks ask for it.

[cbrnr]

It could make sense to support a list of strings here too, wdyt?

You mean to ignore only specific types, e.g. ignore_marker_types=["Comment", "Stimulus"]? I'm not sure how often this is needed, but of course it would be no problem to implement it. I was thinking of just one use case where ignoring types could be needed, namely importing a file that was exported by MNE, in which case all markers will have the Comment type. Since this is a bit arbitrary, it makes sense to remove those "artificial" types on import. In contrast, "native" BrainVision files (e.g. those created by BrainVision Analyzer) will contain various marker types and descriptions in general, so I'd want to keep those (at least by default).

[sappelhoff]

sounds good to me, and agreed with YAGNI for the second suggestion.

[hoechenberger]

ignore_marker_types=False

It could make sense to support a list of strings here too, wdyt?

[hoechenberger]

agreed 👍