Comments (5)
You mean to ignore only specific types, e.g.
ignore_marker_types=["Comment", "Stimulus"]
? I'm not sure how often this is needed
Seems to me like there's clear motivation for "ignore marker types when they're all identical" and uncertain motivation for "let me specify which one(s) to ignore". I'd suggest to assume YAGNI on the second one, and we can overload the param later (to accept list-likes) if folks ask for it.
I'd also consider something like an "always/auto/never" pattern, where "auto" means "ignore them IFF they're all identical". But a simple boolean seems adequate for now --- again, we can update the param later to give more flexibility if folks ask for it.
from mne-python.
It could make sense to support a list of strings here too, wdyt?
You mean to ignore only specific types, e.g. ignore_marker_types=["Comment", "Stimulus"]
? I'm not sure how often this is needed, but of course it would be no problem to implement it. I was thinking of just one use case where ignoring types could be needed, namely importing a file that was exported by MNE, in which case all markers will have the Comment
type. Since this is a bit arbitrary, it makes sense to remove those "artificial" types on import. In contrast, "native" BrainVision files (e.g. those created by BrainVision Analyzer) will contain various marker types and descriptions in general, so I'd want to keep those (at least by default).
from mne-python.
sounds good to me, and agreed with YAGNI for the second suggestion.
from mne-python.
ignore_marker_types=False
It could make sense to support a list of strings here too, wdyt?
from mne-python.
agreed 👍
from mne-python.
Related Issues (20)
- `mne.Brain` fails to set renderer when blocking HOT 1
- BUG: Incompatibility of `sample_weight` with sklearn 1.4+ HOT 2
- BUG: Wrong output for adjacency=False
- bad colormap behavior when brain vlim sliders crossover
- Eyelink: Accept blank recording dates? HOT 3
- Release workflow HOT 16
- The PyQt6 dependency HOT 14
- Logging issue in jupyter kernel when logs are issued in a Thread HOT 4
- Add an SSVEP classification algorithm as a new feature HOT 3
- ValueError: Points have to be provided as one dimensional arrays of length 3. HOT 2
- Request for Sensor Labeling Check in Child-Customized MEG System HOT 2
- Depend on `h5io` and `pymatreader` by default HOT 3
- Tracking issue for (implicit) MNE dependencies still lacking binary wheels for `aarch64` (ARM Linux) HOT 3
- small security upgrade to our upload action
- MAINT: Switch to *_array instead of *_matrix for sparse
- RuntimeWarning for channels with different filter settings on import HOT 12
- Cannot build HTML docs HOT 1
- Export EDF using `mne.export.export_raw`: Signal range error when original data range does not include zero AND data is not equal-length HOT 10
- Add the possibility to provide custom color mapping for channels in raw.plot() HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mne-python.