Comments (12)
I think we should have this:
conda install -c conda-forge mne-icalabel
equivalent topip install mne-icalabel[ica,gui]
2 scenarios:
- Someone installs MNE and then MNE-ICALabel
conda install -c conda-forge mne
conda install -c conda-forge mne-icalabel
Both GUI and ICA dependencies are already resolved by the installation of MNE https://github.com/conda-forge/mne-feedstock/blob/ced43efa6f73d7a3438301c6ac30e48987c46e0a/recipe/meta.yaml#L53-L90
- Someone install directly MNE-ICALabel without installing MNE first
conda install -c conda-forge mne-icalabel
This one will only install mne-base
which does not include the GUI and ICA dependencies https://github.com/conda-forge/mne-icalabel-feedstock/blob/48843682a6dedc1843e5070b447edf9061eb844c/recipe/meta.yaml#L26
So, as for MNE which installs all the extra-dependencies when you do conda install -c conda-forge mne
, let's also add the dep. for GUI and ICA here.
For mne-icalabel-base
, I was thinking about the MNE-installers, but even in their recipes it does not make sense to exclude the extra-dep we (might) need.
from mne-icalabel.
I'm not in a particular rush, so I'm okay w/ waiting for #73 and #93 since the next steps of the work I think are:
- annotating the dataset once or twice when Aaron returns from his summer camp
- begin testing out models for end-to-end training
- benchmark models w/ out of the box stuff like RF
These will probably require some of the feature stuff anyways.
from mne-icalabel.
Yes, I can do it if you want, or we can wait for the bot to pick it up, create the PR, and ask us to fix it because some of the dependencies changed.
from mne-icalabel.
Also, we will need to update the conda-forge recipe with the 'new' dependencies.
We could do something like MNE with:
conda install -c conda-forge mne-icalabel-base
equivalent topip install mne-icalabel
conda install -c conda-forge mne-icalabel
equivalent topip install mne-icalabel[ica,gui]
conda install -c conda-forge mne-icalabel-dev
equivalent topip install mne-icalabel[all]
from mne-icalabel.
Do you remember how to update the conda recipe? Is it this file? Are there writeup instructions anywhere?
https://github.com/conda-forge/mne-icalabel-feedstock/blob/main/recipe/meta.yaml
from mne-icalabel.
Yes, it's the recipe. I know how to do it, and I'll fix it after the Pypi release. Even if the conda-bot picks up the release, it won't automerge the PR as it will detect changes in the dependencies.
Also, now that I'm thinking about it, the mne-icalabel-dev
key won't work. Just as MNE does not have -dev
key, most of the development dependencies are not available on conda.
from mne-icalabel.
I think perhaps we leave conda as just the base install for full functionality perhaps?
E.g. base and GUI?
Cuz everything else is technically dev related and can be added with pip?
from mne-icalabel.
I think we don't need to wait on #73, I'm still not convinced it is ready to be merged. But let's wait on #93, at least because of the format change from array to list for ica.labels_
.
from mne-icalabel.
@hoechenberger just to clarify, for me to update the conda recipe I have to make a PR to the feedstock meta.yml file?
from mne-icalabel.
Also, now that I'm thinking about it, the
mne-icalabel-dev
key won't work. Just as MNE does not have-dev
key
If you're talking about a pre-release version, then that's actually not quite true, you can have different versions of the same package, and that's in fact what we do before new MNE releases to test the installers. The trick is to add a separate branch to the feedstock repo and add a new label. See:
- https://github.com/conda-forge/mne-feedstock/tree/dev
- https://anaconda.org/conda-forge/mne/labels
- https://conda-forge.org/docs/maintainer/knowledge_base.html?highlight=development#pre-release-builds
from mne-icalabel.
Released v0.3 on pypi
from mne-icalabel.
Will close now when conda picks up v0.3
from mne-icalabel.
Related Issues (20)
- [GUI] Missing or non-expandable ICA properties HOT 1
- [DOC] Clarify the types of data to be used HOT 2
- [JOSS] Nitpicks on the paper HOT 1
- No module named 'numpy.typing' HOT 2
- mne_icalabel ImportError HOT 4
- Example render for 0.4 stable website HOT 4
- Possibly want to freeze GH actions at Ubuntu 20.04? HOT 1
- ValueError: need at least one array to concatenate HOT 6
- ONNX/Tensorflow Port HOT 3
- "arrays used as indices must be of integer (or boolean) type" HOT 14
- Set black to max_chars=88 per line
- ICLabel doesn't work with combined MEG/EEG data
- Evaluate and support MEGNet HOT 2
- Guidelines to contribute a new model HOT 4
- Dropdown version selector is broken HOT 1
- Use of IClabel with MEG data. HOT 2
- DOC: tables in dark mode are unreadable HOT 1
- Outdated docs for label_components() HOT 1
- Re-build stable documentation HOT 2
- mne_icalabel ImportError HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mne-icalabel.