Bump minimum Java to Java 8? about nanojson

[mmastrac]

That works for me. I think Java 8 is a reasonable target and Android was mainly the thing holding us back.

[dweiss]

Thanks! I'll go through the code in a spare minute and replace as many things as I can see.

[dweiss]

I filed a PR here. #47

I also noticed the current get(key, default) methods are not really possible to replace with getOrDefault because they currently return the default value if the existing value exists but is not of the right type. I don't know what the rationale for this was but it seems a bit trappy to me. Say, when you're parsing something and use getOrDefault then there is a possibility of passing an invalid input (with a key value of incorrect type) resulting in a silent replacement for the default, without any side-effects.

[mmastrac]

Good point.

Say, when you're parsing something and use getOrDefault then there is a possibility of passing an invalid input (with a key value of incorrect type) resulting in a silent replacement for the default, without any side-effects.

The original design for this was that the parser should be able to traverse any provided JSON without throwing exceptions of any kind (although returning null in cases if no default was provided).

While I still like this guarantee for the get methods, I think we could choose a few options to provide a non-swallowing API (roughly most to least favourable in my view):

• The caller could instruct the reader at construction time not to swallow improperly-typed values and throw a ClassCastException instead (my preference). If we leave the default to swallow those cast exceptions, that would be backwards-compatible.
• Parallel getter methods could be provided
• Provide a callback where any potential class-cast exceptions could be passed in for handling and/or fixing up.

[dweiss]

Ok, fair enough. This didn't look like an oversight - that's why I asked. It can stay as it is, actually. I just found it mildly surprising because I typically prefer things to be the other way around -- break eagerly rather than be lenient. I've spent a great many hours debugging and trying to figure out what's going on when an important exception was quietly swallowed and ignored deep somewhere...

[mmastrac]

Going to close this issue because nanojson now has a minimum required version of Java 8. Thanks for the help!