Coder Social home page Coder Social logo

Comments (4)

flyingkukri avatar flyingkukri commented on June 2, 2024 1

Hi @rcurtin. Yes, that sounds good. Thaks a lot <3~! However I think it will be better if you open a pull request as I don't have any experience with open source contribution.

from mlpack.

rcurtin avatar rcurtin commented on June 2, 2024

Would a getter for classProbabilities suffice? I spent a while thinking about it and it would be tricky to add a getter for the split value, since DecisionTree is not guaranteed to have a single split value. For instance, you could have an n-way split that split with (n - 1) different values into n children. Or, there may be no split value at all: in categorical dimensions, by default (with AllCategoricalSplit), the tree will split into all possible categorical values.

Anyway, the easiest thing to do here would be to provide ClassProbabilities() with documentation pointing out that the values are not class probabilities unless the node is a leaf. If that works for you, I'll open a PR (or you can open one, up to you). Alternately, if you have a proposal for how to provide a SplitValue() member in a safe and flexible way, I'm all ears. 😄

from mlpack.

rcurtin avatar rcurtin commented on June 2, 2024

Sounds good, I opened #3511 to add the new feature. 👍

from mlpack.

rcurtin avatar rcurtin commented on June 2, 2024

#3511 is merged, and so you can either use the git master branch, or wait for the next release of mlpack for the functionality to be stable. 👍

from mlpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.