Coder Social home page Coder Social logo

Comments (21)

nckx avatar nckx commented on August 13, 2024 2

Hi @Mic92! Since issues on your fork are disabled I'm responding here.

There's already a similar maintained fork at https://github.com/teleshoes/acpi_call. Have you reached out to them at all? (They also disable issues, so... yeah.)

You already share the patches that actually matter. Consolidation saves effort and prevents confusion. I for one am not sure which horse to bet on and don't like that I have to.

Thanks (from an ex-Nixer)!

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024 2

Thanks. I give you access to the repository as well.

from acpi_call.

nckx avatar nckx commented on August 13, 2024 2

Wow. That was fast. Thank you both! πŸ˜ƒ

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024 1

I activated the issue tracker on our repo.
@teleshoes do we want to join forces? I actually would prefer to keep it in nix-community since this also gives other people from the NixOS community to step in as required.

from acpi_call.

teleshoes avatar teleshoes commented on August 13, 2024 1

(oh snap, issue tracker was disabled on mine too. also not intentional, just never enabled it)

so, i would LOVE to hand this over. i only maintain it to maintain my other project, tpacpi-bat.

but i dunno, mine has been the defacto upstream for like 5 years now, and lots of people have forked my fork already and submitted pulls. i dont wanna mess with them by closing yet another copy of this repo. what do you think?

from acpi_call.

jamescassell avatar jamescassell commented on August 13, 2024 1

(oh snap, issue tracker was disabled on mine too. also not intentional, just never enabled it)

so, i would LOVE to hand this over. i only maintain it to maintain my other project, tpacpi-bat.

but i dunno, mine has been the defacto upstream for like 5 years now, and lots of people have forked my fork already and submitted pulls. i dont wanna mess with them by closing yet another copy of this repo. what do you think?

Looks like yours should be moved to over to NIX since they have no issues nor PRs yet on theirs. Github is good doing the redirects.

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024 1

We could rename our repository and than move yours and let github handle the rest.

from acpi_call.

teleshoes avatar teleshoes commented on August 13, 2024 1

woo! transferred, seamless redirect works now. thanks!

from acpi_call.

teleshoes avatar teleshoes commented on August 13, 2024

oh right, transfer-ownership is probably the right way to do this. (github will let users transparently fetch from the new location using the old url?)

one caveat: is the nixos fork planning to include nix-specific features that might break acpi_call in other distros?

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024

oh right, transfer-ownership is probably the right way to do this. (github will let users transparently fetch from the new location using the old url?)

Yes github will keep the old clone urls intact but send a message to users that the location has changed.

one caveat: is the nixos fork planning to include nix-specific features that might break acpi_call in other distros?

No. If we ever need this, those patches will be applied in nixpkgs.

from acpi_call.

teleshoes avatar teleshoes commented on August 13, 2024

ok awesome, works for me!

(hmm, why rename? wont we still then just have 2 competing forks? just delete it from github, transfer mine, then cherry-pick your 2 patches into the newly nix-owned repo.)

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024

My idea, was:

  1. Rename ours
  2. Move yours
  3. Delete ours

We have users pulling the source, so I did not want to break the url in between.

from acpi_call.

teleshoes avatar teleshoes commented on August 13, 2024

mm, cant do that tho, because the destination owner cannot have any forks in the same fork-network

EDIT: i think the above is true, but i dont know from experience

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024

Mhm. ok. Maybe I move it back to my own github user instead.

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024

I renamed it for testing: https://github.com/nix-community/acpi_call-legacy

from acpi_call.

teleshoes avatar teleshoes commented on August 13, 2024

ok, ill push the button and see if it works

from acpi_call.

teleshoes avatar teleshoes commented on August 13, 2024

nix-community already has a repository in the mkottman/acpi_call network and You don’t have the permission to create public repositories on nix-community

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024

Ok. I move it to my own user than.

from acpi_call.

teleshoes avatar teleshoes commented on August 13, 2024

gotta delete acpi_call-legacy, and add me to the organization with repo-creating powers

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024

Move is done. I add you to the organization.

from acpi_call.

Mic92 avatar Mic92 commented on August 13, 2024

You should have an invite.

from acpi_call.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.