Coder Social home page Coder Social logo

Comments (27)

shizmebob avatar shizmebob commented on June 13, 2024 2

@lemppari / @mushuthecat my attempt at a fix worked for me. Its available at https://github.com/shizmebob/room-assistant

Pull request made: #1477

You can hack the change in locally pretty easily if you need to as well as its just deleting a few characters. After that I had to wait for my devices to send new information through then restart HA and my warnings cleared. Hopefully one of the maintainers will accept the simple change and publish.

from room-assistant.

lemppari avatar lemppari commented on June 13, 2024 1

@shizmebob, if your change fixes the problem, please release it. At least tell what to change and where. I will then have to try to find out how I can get my installations updated...

from room-assistant.

Duke-Box avatar Duke-Box commented on June 13, 2024 1

@lemppari
Thanks for the file locations.
I have edited the files as per your above post.

Your information is Very much appreciated!

from room-assistant.

austwhite avatar austwhite commented on June 13, 2024 1

The issue is still present as far as naming, but Home Assistant stopped showing it as a repair iten.
Still have until release 2024.2 to fix this, but I have noticed Room Assistant development has slowed right down. I hope the developers are still maintaining it.....
There are a lot less BLE room presense options around now. I guess mm wave technology is slowly replacing them.

from room-assistant.

shizmebob avatar shizmebob commented on June 13, 2024

Hey @lemppari - I see this also. Given there has been no work done on this project for a while I took a look at the source code. I only use the xiaomi-mi integration and I think I just need to change one line to correct this. I will do this locally in my stack but if that will fix your usecase as well I can go to the trouble of a fork in github? Not going to bother if it wont help anyone.

from room-assistant.

mushuthecat avatar mushuthecat commented on June 13, 2024

Hello,

Same issue on my side im using room assistant for presence detection and i also get this warning ?

Any release soon ?

image

from room-assistant.

lemppari avatar lemppari commented on June 13, 2024

@shizmebob @mushuthecat I made that fix locally, but still I get errors in Homeassistant log. Maybe the fix is only for xiaomi-mi integration. I can't find where the entity name is created for MQTT integration.

from room-assistant.

shizmebob avatar shizmebob commented on June 13, 2024

@lemppari - I cant see anything obvious either. What hardware do you use with room-assistant?

from room-assistant.

lemppari avatar lemppari commented on June 13, 2024

@shizmebob All my room-assistants are running on Raspberry Pi Zero W and talking to homeassistant through mqtt.

from room-assistant.

mushuthecat avatar mushuthecat commented on June 13, 2024

Hi,

My Room-Assistant are running on docker container and everithing works perfectly im using them for room detection using BLE on my android devices.

I do not realy understand what we have to do to workaround this issue before the 2024 update...

Regards

from room-assistant.

lemppari avatar lemppari commented on June 13, 2024

It looks like I managed to fix my environment. I am running Raspberry Pis for room-assistants and they talk to Homeassistant via MQTT. I am using Bluetooth-classic integration for monitoring. I don't know how the deployment path goes from Github to npm for my devices, so I just updated the latest version of room-assistant to my clients and modified the code there. I dealed with the .js files on my devices, but here are the changes in the Github .ts versions.

For all the following lines I removed the ${baseName} and ${instanceName} (and following space) from the strings. The .ts files will be converted to .js files in the clients, so they look different but are obviously easily spotted there too.

src/integrations/bluetooth-classic/bluetooth-classic.service.ts
369: ${baseName} Room Presence,

src/integrations/bluetooth-classic/bluetooth-classic.service.ts
354: ${baseName} Tracker,

src/integrations/bluetooth-classic/bluetooth-classic.service.ts
317: ${instanceName} Bluetooth Inquiries

src/status/status.service.ts
97: new Sensor('status-cluster-leader', ${instanceName} Cluster Leader),

src/status/status.service.ts
74: new Sensor('status-cluster-size', ${instanceName} Cluster Size),

from room-assistant.

shizmebob avatar shizmebob commented on June 13, 2024

hey @lemppari - do you want me to give you access to my fork and you can add these fixes there?

from room-assistant.

lemppari avatar lemppari commented on June 13, 2024

@shizmebob Thanks, sure I can do that.

from room-assistant.

shizmebob avatar shizmebob commented on June 13, 2024

@lemppari - you should have an invite now

from room-assistant.

lemppari avatar lemppari commented on June 13, 2024

@shizmebob Thanks! I made changes to your fork. As I mentioned those changes fixed my installation, hopefully there are no unwanted side effects.

I had to remove some retain messages from my Homeassistant MQTT broker manually. I tried various methods for fixing before I found the correct places. Used MQTT Explorer for that.

from room-assistant.

Duke-Box avatar Duke-Box commented on June 13, 2024

Hi,

I get the same warnings. I run room assistant on a pi zero w using classic bluetooth to detect my phones.
I have read this thread but don't understand what I need to do to correct this.

It seems that a local edit of the 'json files is all that is required
Where are the files that need editing on my pi zero located?
If you could point me there I could edit directly.

Or how do I use the fork on Github to upgrade my room-assistant installation?
A step by step instruction would be appreciated, but I would prefer to edit the files locally as I only have one room assistant instance.

Many thanks in advance.

from room-assistant.

mushuthecat avatar mushuthecat commented on June 13, 2024

from room-assistant.

Duke-Box avatar Duke-Box commented on June 13, 2024

@shizmebob @lemppari

Ok I have tried to edit the local files but I cannot find them.

Please can you tell me where the "local" files are so I can edit them. You both say these files can be hacked locally on the device that is running Room Assistant, but where are they? What directory are they in?
I have run a find / *.js and come up with hundreds of files.
I have run a grep -l "$baseName Room Presence" and had no luck as it is taking forever.

ANY help would be appreciated.

from room-assistant.

lemppari avatar lemppari commented on June 13, 2024

@Duke-Box , local files are in the directories under /opt/nodejs/lib/node_modules/room-assistant/dist/:
/opt/nodejs/lib/node_modules/room-assistant/dist/integrations/bluetooth-classic/bluetooth-classic.service.js
/opt/nodejs/lib/node_modules/room-assistant/dist/status/status.service.js

from room-assistant.

lemppari avatar lemppari commented on June 13, 2024

And actually Home Assistant doesn't complain any more. See home-assistant/core#98768 But maybe this could still remain open just in case room-assistant folks wake up.

from room-assistant.

Duke-Box avatar Duke-Box commented on June 13, 2024

from room-assistant.

Scott8586 avatar Scott8586 commented on June 13, 2024

I tend to use room-assistant in a combination of natively on pi zeros, but also in docker containers on pi 3B+s. Will there be a way to get these changes incorporated into a public docker image?

from room-assistant.

github-actions avatar github-actions commented on June 13, 2024

There hasn't been any activity on this issue recently. In an effort to provide a better overview of current issues we automatically clean some of the old ones. Many of them may already be resolved in newer versions of room-assistant.
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

from room-assistant.

TheQue42 avatar TheQue42 commented on June 13, 2024

Since this component, unfortunately seems to be dead, it still an issue.

from room-assistant.

austwhite avatar austwhite commented on June 13, 2024

Unfortunately this is the issue with custom components. They are only as good as the maintenance of the component. Once the maintainer steps back they are slow to be updated

from room-assistant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.