Upgrading to v4.15.0 breaks (@babel/runtime again) about mjml

[iRyusa]

Not sure why you add manually @babel/[email protected] to your package json here ?

npm prune should just fix this no?

[ddolcimascolo]

Hi @iRyusa

I do it to simulate an existing project having the previous version installed. This problem is not new (#2299) and is due to lax dependencies version... I'm using mjml for a very long time, so my @babel/runtime dependency is whatever version satisfied your package.json at that time, actually 7.14.6. MJML now requires a more recent version of @babel/runtime but you didn't bump the dependency in package.json, resulting in a broken package for upgrades.

Indeed the problem does not appear for new installs in new projects because NPM picks the latest available version of @babel/runtime that satisfies the dependency.

According to Babel, you should depend on at least 7.23.8 as per https://github.com/babel/babel/blob/0e5ae8de66d5c1e9ecc3f94daa5bd5d3a920e5a4/packages/babel-helpers/src/helpers/callSuper.ts#L1

Hope this helps,
David

[iRyusa]

Really need to burn everything down and remove completely babel at some point 😮‍💨 .

I'll do a 4.15.2 with updated package.json for everything for today

[ddolcimascolo]

Thx a lot for your help :)

[iRyusa]

For future me : yarn upgrade-interactive doesn't update the package.json when updating a package so I need to do update manually next time 😑

Can you confirm 4.15.2 is good for you @ddolcimascolo ?

[ddolcimascolo]

Yep. All good now.

Thanks again,
Cheers,

David

[ddolcimascolo]

Fixed in 4.15.2