Doesn't work on submodules. about gr

[mixu]

merged & published

[balos1]

I too have found myself wishing this would work with submodules. I believe it can be made to work pretty easily. All that seemingly needs to change is this function. Just need to check if the parent directory has a .gitmodules file, and a .git directory. I will try and submit a PR with these changes.

  git: function(req) {
    var stat;
    try {
      stat = fs.statSync(req.path + '/.git/');
      if (stat.isDirectory()) {
        return true;
      }
    } catch (e) { }
    if (req.format === 'human') {
      console.log('Skipped ' + req.path + ' as it does not have a .git subdirectory.');
    }
    return false;
  },

[spacemoose]

Hey, super. Thanks very much for that.

[bimlas]

It works if the submodule is the first child of the root directory but not works if the submodule is in foo/more/than/one/level/bar. I don't speak Java, but I know that some kind of globbing should do the trick here, or a loop like:

      while !empty(req.path) {
        var parentPath = path.dirname(req.path);
        try {
          stat = fs.statSync(parentPath + '/.gitmodules');
          if (!stat.isFile()) {
            var req.path = removeLastPart(req.path);
          }
        } catch (e) { }
      }
      return empty(req.path) ? false : true;

[bimlas]

Another option: if .git is a file instead of a directory (so it's a submodule), then read the contents, for example:

gitdir: ../../../../.git/more/than/one/level/bar

If it contains gitdir: than it's a submodule.

[bimlas]

Please help me in #65

[bimlas]

Just finished #65, please test it.