Comments (4)
Dear @amyspark,
we're currently 100% occupied with other research projects. It would be helpful if you could look into this yourself and post a PR to address the underlying issue.
Best,
Wenzel
from mitsuba.
I'm no expert, but I'll do my best.
I started by intercepting the division by zeros, which in my case were caused by the integrator attempting to calculate the incident light here:
mitsuba/src/librender/integrator.cpp
Line 183 in 933a057
When Mitsuba intersects the sampled ray with the hair, this query
mitsuba/src/librender/integrator.cpp
Line 150 in 933a057
Intersection
with the shading frame and UV partial position all set to zero. This is the same with any bsdf, and when it tries normalising that vector, it all fails.from mitsuba.
I tried git bisect
ing since 1ca0413 (when you bumped Mitsuba to 0.5.0). I couldn't get Mitsuba to compile there (lots of Boost uncaught exceptions, clang complaining about libstdc++
, et al) so I resorted to manually looking backwards starting from the latest commit.
Counting from today, the first working commit I could find is b8480a3. The first bad one I could find is 8365668.
git bisect
ing them tells me the bug was introduced by ce80ddc, which is consistent with the shading frame issue I had observed.
EDIT: I've narrowed it down to util.cpp
and/or skdtree.h
. The changes in hair.cpp
only remove the shading frame computation.
from mitsuba.
I've finally found the cause of the bug. It seems that previously, Hair
's shading frame was initialized to the geometry frame with no further changes:
Line 848 in 0a49106
Now, the shading frame calculation is standardized with the rest of the shapes. This was not done anywhere previously:
mitsuba/include/mitsuba/render/skdtree.h
Line 424 in ce80ddc
EDIT: The reason why this all breaks down is because
its.uv
, its.dpdu
and its.dpdv
are never initialized at fillIntersectionRecord
:Line 827 in 933a057
from mitsuba.
Related Issues (20)
- How to save the albedo map, depth map, normal map and roughness map?
- Why not stop when the BSDF sampling ray hit the luminaire in MIPathTracer HOT 1
- Even in 'scons-python3' branch 'data/qt5.py' is still python2-stylistic HOT 2
- Set background color
- Add Mistuba 0.6.0 binaries to website?
- AttributeError: 'SConsEnvironment' object has no attribute 'has_key':
- 【MAC】build failed HOT 2
- Compile Mitsuba0.6 with VS2017 on Win11 HOT 1
- Compile failed when I use the openexr header file
- Ubuntu 20.04 compile error for GLEWContextStruct HOT 2
- Compilation failed on MacOS Big Sur HOT 1
- Can I adjust the absorption and scattering coefficients directly?
- Medium Rendering Issue HOT 1
- environment map HOT 1
- translate env map in spherical sensor HOT 4
- Where can I find some references to the algorithms implemented?
- Different fov along different axis HOT 1
- Missing Channel Names when using AOV Integrator HOT 2
- White noise in spectral rendering
- How to create a series of .xml by using mitsuba HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mitsuba.