Malformed SANs, or SANs of type other than DNS or IP Address, may raise "UnicodeError: label too long in IDNA decode" in certs.dummy_cert() about mitmproxy

[mhils]

Thanks for the detailed write-up! I agree with everything here, we should just handle SANs properly and represent them as cryptography.x509.GeneralNames and not a list of strings. I've just posted #6537, which should fix this. This is hard-to-get-right, so a review would be super welcome! 😃

[justinsteven]

Aha, that changelog entry makes complete sense 😁

I'm not as familiar with the wider codebase as I'd like to be, so I'm not sure I'd make a great reviewer. If I can I'll take a look.

Thanks for jumping on this so quickly!

[mhils]

I'm not as familiar with the wider codebase as I'd like to be, so I'm not sure I'd make a great reviewer. If I can I'll take a look.

Thanks! If you can verify that this fixes the issues you were seeing that'd be splendid, but absolutely no worries if you are busy otherwise. :)