Coder Social home page Coder Social logo

Comments (10)

Rafiot avatar Rafiot commented on August 11, 2024 1

Alright, I started to look at that:

  1. will require more detailed investigation as it is converted to an integer at a place that makes it somewhat hard to change. nevermind, fixed: 1d24c1b
  2. the local key in tag isn't in the schema at all, can you give more details on how you got the warning, please?

from pymisp.

Rafiot avatar Rafiot commented on August 11, 2024 1

It is a bug on MISP side, that should be handled as a boolean, and not 0/1. It will be fixed in MISP asap.

from pymisp.

iglocska avatar iglocska commented on August 11, 2024 1

FYI, the fix is now on develop and will go into the release later today.

from pymisp.

imranmmd17 avatar imranmmd17 commented on August 11, 2024

@Rafiot - Can you please look into it. Thanks.

from pymisp.

Rafiot avatar Rafiot commented on August 11, 2024

The events generated by PyMISP work just fine on MISP, so it is probably more an issue with the schema itself.

from pymisp.

Rafiot avatar Rafiot commented on August 11, 2024

ok, update on that: PyMISP to_json returns a blob that is compatible with what MISP expects (float or int) when the schema says string.

We could consider to add a method that casts the int/float to str, but the default will stay the same for backward compatibility reasons. What is your use-case?

from pymisp.

imranmmd17 avatar imranmmd17 commented on August 11, 2024

Thanks @Rafiot. Our requirement is to export the MISP event and ensure it passes the MISP standard schema before passing it on to the data pipeline for subsequent processing. At every stage of the pipeline, the very thing they do is schema validation again.

from pymisp.

imranmmd17 avatar imranmmd17 commented on August 11, 2024
  1. Thanks @Rafiot for fixing the timestamp. LGTM.
  2. When an event is downloaded using MISP WebUI, the tag's local attribute is number (i.e. int). Whilst the API event.to_json() returns it as str. Yes the local key isn't in the schema, however we've added it for our use case to match with the WebUI downloaded event. We expect the outcome to be the same whether an event is d/l using WebUI or using API. It's not a show stopper, but good to have consistency.

from pymisp.

dragsu avatar dragsu commented on August 11, 2024

@Rafiot I want to extend this. What is the reason for the blanket _int_to_str(to_return) call inside to_dict method in AbstractMISP.py? As a result, Tag's local values (0 and 1) get changed into string values ("0" and "1") , which is unexpected.

P.S
I have added a fix for this #1171

from pymisp.

dragsu avatar dragsu commented on August 11, 2024

MISP v2.4.187 got an upstream fix for this. Now local values are represented as true and false.

from pymisp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.