mirroar / topfit

A World of Warcraft Addon that helps you with Equipment choices.

Hi there 👋

topfit's Issues

Update code to account for Unique Equipped

Once you complete the quest to turn [Solium Band of Endurance] into [Timeless Solium Band of the Bulwark], TopFit doesn't know how to handle both rings. Both are better than anything else, so it just shows a long chain of, "You can only have one..." errors.

That's fine. But the issue then is that it's really random which one gets equipped. I hit the "Play" button on the character menu... sometimes it's my 640 ring, sometimes it's the 680 ring.

Ideally it should check the "Unique Equipped" set type and only use one from each.

! This is a nice to have, clearly the easiest thing is for me to put my old ring in the bank.

LUA error

Not 100% on how to read this, but I get hundreds of these on my bank toon full of BOA gear.

Issues

/topfit doesn't open the config window

Changing specs to auto equip, when you change the 2nd spec you have to re-change the first

Nice to have - option on first login to detect class

Hunter's still get staves equipped instead of bows / crossbows / guns.

Interface\FrameXML\PaperDollFrame.lua:1841: in function `PaperDollItemSlotButton_OnEnter'
[string ":OnEnter"]:1: in function <[string ":OnEnter"]:1>
self =

{
getCompareItems = defined @interface\AddOns\TopFit\modules\tooltip.lua:124
class = defined @interface\AddOns\TopFit\TopFit.lua:13
WeightsPlugin = {
}
DefaultCalculation = {
}
GetCapValue = defined @interface\AddOns\TopFit\modules\options.lua:266
replaceTokensInString = defined @interface\AddOns\TopFit\modules\tooltip.lua:55
ReduceGemList = defined @interface\AddOns\TopFit\modules\calculation.lua:494
UpdateVirtualItemButtons = defined @interface\AddOns\TopFit\modules\ui.lua:231
ImportPlugin = {
}
getComparePercentage = defined @interface\AddOns\TopFit\modules\tooltip.lua:223
GetCachedItem = defined @interface\AddOns\TopFit\inventory.lua:699
UpdateUIWithCalculationProgress = defined @interface\AddOns\TopFit\modules\calculation.lua:77
PlayerCanDualWield = defined @interface\AddOns\TopFit\modules\utilities.lua:3
RemoveLowScoreItemsFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:427
title = "TopFit"
SetCapActive = defined @interface\AddOns\TopFit\modules\options.lua:307
IsOnehandedWeapon = defined @interface\AddOns\TopFit\inventory.lua:707
RunAutoUpdate = defined @interface\AddOns\TopFit\TopFit.lua:578
scanTooltip = TFScanTooltip {
}
Unfit = {
}
IsInitialized = defined @interface\AddOns\TopFit\TopFit.lua:429
tests = {
}
eventHandler = {
}
SmartCalculation = {
}
SetAfterCapStatValue = defined @interface\AddOns\TopFit\modules\options.lua:302
Calculation = {
}
DeleteSet = defined @interface\AddOns\TopFit\modules\options.lua:197
UnregisterCallback = defined @interface\AddOns\AckisRecipeList\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:179
db = {
}
InitializeCapTable = defined @interface\AddOns\TopFit\modules\options.lua:312
eventFrame = {
}
emptySet = {
}
AutoEquipSet = defined @interface\AddOns\TopFit\TopFit.lua:612
GetSetByID = defined @interface\AddOns\TopFit\TopFit.lua:662
presets = {
}
RemoveItemsBelowThresholdFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:396
initialized = false
ItemHasSpecialBonus = defined @interface\AddOns\TopFit\modules\trinketlogic.lua:83
gemIDs = {
}
getTokenAndArguments = defined @interface\AddOns\TopFit\modules\tooltip.lua:117
Plugin = {
}
RemoveBindOnEquipItemsFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:349
GetLinkID = defined @interface\AddOns\TopFit\modules\utilities.lua:13
StoppedCalculation = defined @interface\AddOns\TopFit\modules\ui.lua:43
GetEquippableItems = defined @interface\AddOns\TopFit\inventory.lua:583
PlayerHasTitansGrip = defined @interface\AddOns\TopFit\modules\utilities.lua:9
InsertIntoItemSetNames = defined @interface\AddOns\TopFit\modules\ui.lua:316
SetCapValue = defined @interface\AddOns\TopFit\modules\options.lua:297
GetAvailableItemSetNames = defined @interface\AddOns\TopFit\modules\ui.lua:284
IsItemBoE = defined @interface\AddOns\TopFit\inventory.lua:565
SetCurrentCombination = defined @interface\AddOns\TopFit\modules\ui.lua:65
ResetProgress = defined @interface\AddOns\TopFit\modules\ui.lua:57
GetSetItemFromSlot = defined @interface\AddOns\TopFit\inventory.lua:31
SetProgress = defined @interface\AddOns\TopFit\modules\ui.lua:50
currentPlugins = {
}
ClearCache = defined @interface\AddOns\TopFit\inventory.lua:26
GetForcedItems = defined @interface\AddOns\TopFit\modules\options.lua:322
InvokeAll = defined @interface\AddOns\TopFit\TopFit.lua:684
CalculationHasCompleted = defined @interface\AddOns\TopFit\modules\calculation.lua:91
ShowTooltip = <

Getting a few LUA errors with latest build

Downloaded latest. Saw following errors. Did a clean install -- deleted all saved variables prior to logging in.

LUA Error

Got this error after clearing out all variables and doing a fresh install from Curse. Once I logged out and in again... I couldn't reproduce the issue. But until I did that I had no menu to select the class role from and I got errors.

[Error 0000000039377700] captured, click the link for more information.
[Error 0000000039377700] captured, click the link for more information.
[Error 0000000039377700] captured, click the link for more information.
[Error 0000000039377700] captured, click the link for more information.
[Error 0000000039377700] captured, click the link for more information.
[Error 0000000039377700] captured, click the link for more information.
There are too many errors in your UI. As a result, your game experience may be degraded. Disable or update the failing addons if you don't want to see this message again.
Veliraina has gone offline.
Interface\AddOns\TopFit\TopFit-6.0v1.lua:683: in function GetSetByID' Interface\AddOns\TopFit\modules\ui.character.lua:344: in function <Interface\AddOns\TopFit\modules\ui.character.lua:339> Interface\AddOns\TopFit\modules\ui.character.lua:365: in function <Interface\AddOns\TopFit\modules\ui.character.lua:363> [C]: in functionPaperDollItemSlotButton_OnShow'
[string ":OnShow"]:1: in function <[string ":OnShow"]:1>
[C]: in function Show' Interface\FrameXML\UIParent.lua:1994: in functionSetUIPanel'
Interface\FrameXML\UIParent.lua:1838: in function ShowUIPanel' Interface\FrameXML\UIParent.lua:1709: in function <Interface\FrameXML\UIParent.lua:1705> [C]: in functionSetAttribute'
Interface\FrameXML\UIParent.lua:2468: in function ShowUIPanel' Interface\FrameXML\CharacterFrame.lua:21: in function <Interface\FrameXML\CharacterFrame.lua:5> [C]: in functionToggleCharacter'
[string "TOGGLECHARACTER0"]:1: in function <[string "TOGGLECHARACTER0"]:1>
slotButton = CharacterHeadSlot {
0 =
checkRelic = false
IconBorder = {
}
hasItem = 1
icon = CharacterHeadSlotIconTexture {
}
ignoreTexture = {
}
hover = frame {
}
pushed = frame {
}
template = "Default"
popoutButton = CharacterHeadSlotPopoutButton {
}
backgroundTextureName = "interface\paperdoll\UI-PaperDoll-Slot-Head.blp"
Count = CharacterHeadSlotCount {
}
backdropTexture = {
}
UpdateTooltip = defined @interface\FrameXML\PaperDollFrame.lua:1835
searchOverlay = CharacterHeadSlotSearchOverlay {
}
count = 1
glossTex = true
}
slotID = 1
forcedItemsInSlot =

{
}
ns = {
RemoveWrongArmorTypesFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:324
class = defined @interface\AddOns\TopFit\TopFit.lua:13
WeightsPlugin = {
}
DefaultCalculation = {
}
GetCapValue = defined @interface\AddOns\TopFit\modules\options.lua:266
replaceTokensInString = defined @interface\AddOns\TopFit\modules\tooltip.lua:55
ReduceGemList = defined @interface\AddOns\TopFit\modules\calculation.lua:503
UpdateVirtualItemButtons = defined @interface\AddOns\TopFit\modules\ui.lua:231
Warning = defined @interface\AddOns\TopFit\TopFit.lua:90
getComparePercentage = defined @interface\AddOns\TopFit\modules\tooltip.lua:223
CalculateSets = defined @interface\AddOns\TopFit\modules\calculation.lua:34
UpdateUIWithCalculationProgress = defined @interface\AddOns\TopFit\modules\calculation.lua:77
PlayerCanDualWield = defined @interface\AddOns\TopFit\modules\utilities.lua:3
RemoveLowScoreItemsFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:437
SetCapActive = defined @interface\AddOns\TopFit\modules\options.lua:307
IsOnehandedWeapon = defined @interface\AddOns\TopFit\inventory.lua:746
RunAutoUpdate = defined @interface\AddOns\TopFit\TopFit.lua:598
IsInitialized = defined @interface\AddOns\TopFit\TopFit.lua:449
SetAfterCapStatValue = defined @interface\AddOns\TopFit\modules\options.lua:302
Calculation = {
}
DeleteSet = defined @interface\AddOns\TopFit\modules\options.lua:197
scanTooltip = TFScanTooltip {
}
db = {
}
Unfit = {
}
eventFrame = {
}
eventHandler = {
}
AutoEquipSet = defined @interface\AddOns\TopFit\TopFit.lua:632
collectEquippableItems = defined @interface\AddOns\TopFit\TopFit.lua:453
presets = {
}
RemoveItemsBelowThresholdFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:405
UnregisterCallback = defined @interface\AddOns\AckisRecipeList\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:179
ItemHasSpecialBonus = defined @interface\AddOns\TopFit\modules\trinketlogic.lua:85
GetAfterCapStatValue = defined @interface\AddOns\TopFit\modules\options.lua:275
getTokenAndArguments = defined @interface\AddOns\TopFit\modules\tooltip.lua:117
Plugin = {
}
RemoveBindOnEquipItemsFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:355
emptySet = {
}
StoppedCalculation = defined @interface\AddOns\TopFit\modules\ui.lua:43
GetEquippableItems = defined @interface\AddOns\TopFit\inventory.lua:616
RenameSet = defined @interface\AddOns\TopFit\modules\options.lua:223
initialized = false
SetCapValue = defined @interface\AddOns\TopFit\modules\options.lua:297
gemIDs = {
}
IsItemBoE = defined @interface\AddOns\TopFit\inventory.lua:598
GetLinkID = defined @interface\AddOns\TopFit\modules\utilities.lua:13
PlayerHasTitansGrip = defined @interface\AddOns\TopFit\modules\utilities.lua:9
GetSetItemFromSlot = defined @interface\AddOns\TopFit\inventory.lua:37
InsertIntoItemSetNames = defined @interface\AddO

Add recognition of "Indestructible" stat

But... nobody will ever use this. (=

Math is off for Some Items

Math is off for Resto Shaman. Weights look right, but it's not putting the right gear on.

Says that [Amaranthine Signet of the Decimator] 496
+27 Int
+40 Stam
+26 Critical Strike

is better than [Wicked Witch's Signet] 540
+40 Int
+61 Stam
+27 Critical Strike
+27 Spirit

Other ring that is equipped is [The Horseman's Ring] 540, no conflict of unique equipped.

Add recognition of "Movement Speed" stat

Question: How does Max Health work for calculations?

TRIVIAL as people should not be using PVP trinkets, but question came up:

Heard from a Blood tank that the first trinket was coming up over the second.

[Primal Combatant's Insignia of Victory]
+145 Versatility (1.12% @ L100)
Equip: When you deal damage you have a chance to gain 505 Strength for 20 sec.

[Primal Combatant's Emblem of Tenacity]
+171 Stamina
Use: Increases maximum health by 7202 for 15 sec. Shares cooldown with other Battlemaster's trinkets. (2 Min Cooldown)

Does the "Adds health" proc get factored into the calculations? Doesn't look like the proc was getting factored in... Max Health, as a Tank, should basically be counted as "Adds 7202 health" -- whatever that is in Stamina -- 1/8th of the time.

Creating sets overwrites existing equipment sets

When creating a new set from a preset, TopFit replaces any set with a matching name.
Proposal: TopFit should not save a set's items when it has not been instructed to calculate. That way, existing sets remain intact.

Fix enchant stats

As of 6.0.2, the stats of many enchants have changed due to item squish. Also make sure enchants still get detected correctly.

Add dual-wield to presets

Depending on the spec (probably) or the preset, dual wielding should automatically be enabled for some sets.

Propose defaulting option for "Force Armor Type" to True.

Propose defaulting "Force Armor Type" to True.

Propose defaulting "Update set automatically when you change your spec" to True.

Propose keeping "Include set in tooltip" to True.

Propose defaulting "Show set values in tooltip" to True.

Suggest default settings for new users

As much as I dislike windows popping up on login, the addon is hardly functional if not set up correctly.

When using the AddOn for the first time on a character, show a quick dialog that allows the user to:

• Create sets according to the character's specs (or a specific spec if below level 10)
• activate or deactivate auto-equip
• give them a little pointer where settings can be changed

Don't rely on EquimentManager to save equipment sets

That would allow calculating and saving a set without actually equipping it.

Make equip aware of itemSubType

Put some thought into this.

Above the stats people put in, there should be some Class / Role weights that trump everything else. This way a Rogue doesn't get a spell power off-hand equipped.

Here are the basic rules:

Hunters - Must be a bow, gun, or crossbow.

Rogues, Fury / Arms Warriors, Enhancement Shaman, Death Knights, Monks - OH and MH items must have DPS. (Should also have a check box for "Must Use 2H" probably near "Force Armor Type"... in which case they would be limited to selecting from 2H Axes, Maces, Polearms, etc...)

Protection Warriors, Protection Paladins - OH must have armor on it. Another checkbox, "Must Use Shield" next to "Force Armor Type" for that profile.)

All of this would require tweaks to the code to allow for recognition of the itemSubType -- which I think we can pull up using the API.

Lastly we'd need to split up OH and MH Weapon DPS and Weapon Speed (DPS alone is probably fine), and then when doing the check just calculate for slot 16 and slot 17 differently. Run the MH calc, then run the OH calc... so really it's just making the code aware to run the calc a second time against the unselected gear for slot 17, using the OH speed and DPS.

In my head it's done. I just need to learn LUA better. (=

Clear saved variables on addon update

When coming from a pre 6.0-version, saved variables will not be compatible anymore and most sets will contain outdated weights and stats anyway.

Add recognition of "Bonus Armor" stat

MiniMap Icon needs a tooltip

Would suggest:

TopFit
Set 1 - Score
Set 2 - Score
Set N - Score

That way we can still see the scores for each set in a way that isn't too in-your-face for more casual players.

Need to reset existing sets when new weights are published

Had some issues with friends who didn't see any benefits because they didn't manually delete their old profiles. Walked them through how to delete those, and once they did and created new sets using the new weights, things were fine.

Would suggest that we force a reset every time weights are re-calculated and also pop an alert message if possible, "Hey we reset your gear with new weights. Go fix it!"

Update Curse Client short description text

http://grab.by/CrBo

Updated copy:

Automatically equips your best gear based on validated preset or custom attribute weights.

Propose defaulting option for "Update set automatically when you change your spec" to True.

Currently the workflow on this is a little weird... we can't update automatically if no sets are defined.

I think we should pop a window whenever someone first installs the game, and again when we change the weights... Window should say, "Welcome to TopFit, please select your roles:"

And then have two menus - Spec 1, and Spec 2.

And a "Save" button.

Once selected it would add those two Weight Sets, and set up automatic updating for gear, and automatic updating when the player changed their spec.

Merge import / export into weights plugin

Import / export does not need separate tab in the config window. Should still be in a separate file, though.

Low-level Trinkets not equipping

Had this issue today while leveling an alt. When I got a new dungeon trinket it wouldn't equip. Dungeon Armor did equip, just not the Dungeon Trinket.

Update Readme

Make it snazzy using markdown and such :) Probably has some outdated info as well.

Repositionable Calculate Button

By theondry at http://wow.curseforge.com/addons/topfit/tickets/1-repositionable-calculate-button/

It's current location conflicts with where "Cosplay" puts it's tick marks to enable and disable cloak and helm.
Is there a way to detect other stuff in the same spot and move somewhere safer?

(I would argue for moving the calculate button to the "Topfit" tab because I am less likely to calculate item sets than I am to toggle my helm or cloak. This is, however, a personal bias.)

I'm going to post something similar over on the Cosplay page.

edit: It's Leatrix Plus that puts the buttons there, not Cosplay.

Addon not working with Monks

Addon does not seem to be working with Monks. Sets based on specs are not created, and furthermore - the drop down menu in the character pane doesn't work so you cannot create your own equipment set for TopFit to use. Basically forced to use "Default" set, which limits you to one equipment set.

Fix Gem Stats

As of 6.0.2, gem stats have changed substantially due to item squish. They will need to be re-imported.

Propose defaulting option for "Show set values in tooltip" to True.

Gear not equipping correctly

I was leveling a Blood DK, and it started swapping in Gray mail items over Blue Str Plate. I put "Force Armor Type" and that sort of fixed it, but it kept putting on inferior items -- my old gear over the new gear. In the tooltip it would say that the new gear was better, but it refused to equip it.

Error in ns.GetSetByID when all sets are deleted

Either make sure TopFit works fine when there are no sets, or make sure there is always at least an empty set.

Pawn string import drops values

By Altiokis at http://www.wowinterface.com/downloads/info16177-TopFit.html#comments

When importing the string from Pawn, several of the values were dropped.

Attack Power
Ranged DPS
Ranged Speed

Here is the string if you want to test it.

( Pawn: v1: "Beast No Hit": IsOffHand=-1000000, RangedDps=90, Is2HMace=-1000000, IsMace=-1000000, CritRating=31, IsStaff=-1000000, Agility=100, HasteRating=37, IsDagger=-1000000, Speed=74, MetaSocketEffect=16000, IsPolearm=-1000000, IsFrill=-1000000, Is2HAxe=-1000000, IsWand=-1000000, IsShield=-1000000, IsSword=-1000000, IsFist=-1000000, Stamina=0.1, ExpertiseRating=64, Is2HSword=-1000000, IsPlate=-1000000, IsAxe=-1000000, Ap=38 )

Add recognition of "Avoidance" stat

Auto-Calculation does not notice new items

Happens mostly with quest rewards.

Add handling for the new "armor bonus", "versatility", "multistrike" and "life leech" stats

Add recognition of "Cleave" stat

But nobody will ever use this... (=

Weights need to be updated for WoD

Apparently the weights have shifted now.

Let me know if I can pull a spreadsheet for you.

Can't open Character Window Menu or Addon Settings

In latest version. Menu is empty, and clicking on minimap does nothing.

Talend UI not initializing properly on login

Probably because we are reusing the Talent UI frame and some initialization code gets confused.

Collect data for inactive stats

Currently you can't really calculate sets when you're not in the correct specialization. As Enhancer, I see no int on my items and can't correctly calculate my Resto or Elemental sets.

Menu Not Working / Minimap Icon Not Showing Up

Updated to latest from Curse, deleted all previously saved settings.

Logged in, didn't see minimap button (talked about in release notes), and didn't see Weight Set selection menu on Character screen.

@Mirroar

Hunters should only have bow / gun / crossbow equipped

Any way to have it filter out Druid staves?

Allow import of weights from AskMrRobot

@Gogo1951 suggested in #25:

If you add this, please make sure it can read the copy / paste from AMR. They come out looking like:

Strength 1.00
BonusArmor 0.95
Stamina 0.80
Armor 0.70
Mastery 0.64
Multistrike 0.60
Haste 0.50
Versatility 0.45
CriticalStrike 0.40
AttackPower 0.20
MainHandDps 0.20
MovementSpeed 0.15
Avoidance 0.10
Leech 0.05

TopFit window does not show addon information

http://grab.by/BsBw

I deleted all saved variables before installing latest from Github. The in-game window doesn't have anything in it when I open it. Tried it with all other addons disabled as well, same result.

Dual-wielding is nto working on my rogue

TopFit equips a crossbow instead because it has Agi on it.

Update so that Level 90-99 Dungeon Gear will Equip Properly

#27

This is still not updating 90-99 dungeon level gear correctly.

Says ring, bracers, legs, etc. are better than what I have on in the tool tip, but doesn't equip the item.

http://grab.by/CrZ2

Split auto-calculating and auto-equipping

Just because I want a set auto-equipped when changing specs does not mean it should also be recalculated every time that happens.

Update AddOn description and Screenshots

Both WoWInterface and Curse need an update showing off the cool new features in 6.0

LUA Errors

Postal: Processing Message 1: Gore-Steeped Skullforge Reaver
[Error 000000002FFD5940] captured, click the link for more information.
[Error 000000002FFD5940] captured, click the link for more information.
[Error 000000002FFD5940] captured, click the link for more information.
[Error 000000002FFD5940] captured, click the link for more information.
[Error 000000002FFD5940] captured, click the link for more information.
[Error 000000002FFD5940] captured, click the link for more information.
[Error 000000002FFD5940] captured, click the link for more information.
There are too many errors in your UI. As a result, your game experience may be degraded. Disable or update the failing addons if you don't want to see this message again.
Interface\AddOns\TopFit\TopFit-5.3v1.lua:683: in function GetSetByID' Interface\AddOns\TopFit\modules\ui.character.lua:348: in function <Interface\AddOns\TopFit\modules\ui.character.lua:343> Interface\AddOns\TopFit\modules\ui.character.lua:369: in function <Interface\AddOns\TopFit\modules\ui.character.lua:367> [C]: in functionPaperDollItemSlotButton_OnShow'
[string ":OnShow"]:1: in function <[string ":OnShow"]:1>
[C]: in function Show' Interface\FrameXML\UIParent.lua:1994: in functionSetUIPanel'
Interface\FrameXML\UIParent.lua:1838: in function ShowUIPanel' Interface\FrameXML\UIParent.lua:1709: in function <Interface\FrameXML\UIParent.lua:1705> [C]: in functionSetAttribute'
Interface\FrameXML\UIParent.lua:2468: in function ShowUIPanel' Interface\FrameXML\CharacterFrame.lua:21: in function <Interface\FrameXML\CharacterFrame.lua:5> [C]: in functionToggleCharacter'
[string "TOGGLECHARACTER0"]:1: in function <[string "TOGGLECHARACTER0"]:1>
slotButton = CharacterHeadSlot {
0 =
checkRelic = false
IconBorder = {
}
hasItem = 1
icon = CharacterHeadSlotIconTexture {
}
ignoreTexture = {
}
hover = frame {
}
pushed = frame {
}
template = "Default"
popoutButton = CharacterHeadSlotPopoutButton {
}
backgroundTextureName = "interface\paperdoll\UI-PaperDoll-Slot-Head.blp"
Count = CharacterHeadSlotCount {
}
backdropTexture = {
}
UpdateTooltip = defined @interface\FrameXML\PaperDollFrame.lua:1835
searchOverlay = CharacterHeadSlotSearchOverlay {
}
count = 1
glossTex = true
}
slotID = 1
forcedItemsInSlot =

{
}
ns = {
getCompareItems = defined @interface\AddOns\TopFit\modules\tooltip.lua:124
class = defined @interface\AddOns\TopFit\TopFit.lua:13
WeightsPlugin = {
}
DefaultCalculation = {
}
GetCapValue = defined @interface\AddOns\TopFit\modules\options.lua:266
replaceTokensInString = defined @interface\AddOns\TopFit\modules\tooltip.lua:55
ReduceGemList = defined @interface\AddOns\TopFit\modules\calculation.lua:503
UpdateVirtualItemButtons = defined @interface\AddOns\TopFit\modules\ui.lua:231
ImportPlugin = {
}
getComparePercentage = defined @interface\AddOns\TopFit\modules\tooltip.lua:223
GetCachedItem = defined @interface\AddOns\TopFit\inventory.lua:713
UpdateUIWithCalculationProgress = defined @interface\AddOns\TopFit\modules\calculation.lua:77
PlayerCanDualWield = defined @interface\AddOns\TopFit\modules\utilities.lua:3
RemoveLowScoreItemsFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:437
title = "TopFit"
SetCapActive = defined @interface\AddOns\TopFit\modules\options.lua:307
IsOnehandedWeapon = defined @interface\AddOns\TopFit\inventory.lua:721
RunAutoUpdate = defined @interface\AddOns\TopFit\TopFit.lua:598
scanTooltip = TFScanTooltip {
}
Unfit = {
}
IsInitialized = defined @interface\AddOns\TopFit\TopFit.lua:449
tests = {
}
eventHandler = {
}
SmartCalculation = {
}
SetAfterCapStatValue = defined @interface\AddOns\TopFit\modules\options.lua:302
Calculation = {
}
DeleteSet = defined @interface\AddOns\TopFit\modules\options.lua:197
UnregisterCallback = defined @interface\AddOns\AckisRecipeList\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:179
db = {
}
InitializeCapTable = defined @interface\AddOns\TopFit\modules\options.lua:312
eventFrame = {
}
emptySet = {
}
AutoEquipSet = defined @interface\AddOns\TopFit\TopFit.lua:632
GetSetByID = defined @interface\AddOns\TopFit\TopFit.lua:682
presets = {
}
RemoveItemsBelowThresholdFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:405
initialized = false
ItemHasSpecialBonus = defined @interface\AddOns\TopFit\modules\trinketlogic.lua:85
gemIDs = {
}
getTokenAndArguments = defined @interface\AddOns\TopFit\modules\tooltip.lua:117
Plugin = {
}
RemoveBindOnEquipItemsFromItemList = defined @interface\AddOns\TopFit\modules\calculation.lua:355
GetLinkID = defined @interface\AddOns\TopFit\modules\utilities.lua:13
StoppedCalculation = defined @interface\AddOns\TopFit\modules\ui.lua:43
GetEquippableItems = defined @interface\AddOns\TopFit\inventory.lua:591
PlayerHasTitansGrip = defined @interface\AddOns\TopFit\modules\utilities.lua:9
InsertIntoItemSetNames = defined @interface\AddOns\TopFit\modules\ui.lua:316
SetCapValue = defined @interface\AddOns\TopFit\modules\options.lua:297
GetAvailableItemSetNames = defined @interface\AddOns\TopFit\modules\ui.lua:284
IsItemBoE = defined @interface\AddOns\TopFit\inventory.lua:573
SetCurrentCombination = defined @interface\A

Slash command doesn't open config

Typing /topfit just opens the general settings, not the config for this specific addon.

Setting specs to Auto Equip in settings gets weird behavior

When I set my primary spec to something, then change the secondary spec, it sets the primary up as "custom" until I change it back to what I originally set it to.

Better behavior here would be for it to not set the primary to "custom" but even better... in three parts:

1 - Have a prompt when you first load the addon asking you to enable auto-equip.

2 - Having a menu based on the class you are, showing all the different options:

So like hunters would see:

Spec 1: (Drop Down Menu)
PVP - Hunter - Beastmaster
PVP - Hunter - Marksman
PVP - Hunter - Survival
PVE - Hunter - Beastmaster
PVE - Hunter - Marksman
PVE - Hunter - Survival

Spec 2: (Drop Down Menu)...

3 - Step 3, changing the menu on the player profile to:

PVP - Hunter - Beastmaster
PVP - Hunter - Marksman
PVP - Hunter - Survival
PVE - Hunter - Beastmaster
PVE - Hunter - Marksman
PVE - Hunter - Survival
Add Custom