Machine translation 500 error about accent

[simonprev]

Much easier to use! Thanks @ChxGuillaume !

Screen.Recording.2024-04-04.at.9.37.48.PM.mov

[ChxGuillaume]

After some investigation, it seems to come from some frontend GraphQL request in this component/function:

accent/webapp/app/components/inline-machine-translate/component.ts

Lines 23 to 40 in c0c8d83

	submitTask = dropTask(async (targetLanguageSlug: string) => {
	this.args.onUpdatingText();
	const variables = {
	projectId: this.args.project.id,
	text: this.args.text,
	targetLanguageSlug
	};
	const {data} = await this.apollo.client.query({
	query: projectTranslateTextQuery,
	variables
	});
	if (data.viewer.project.translatedText?.text) {
	this.args.onUpdateText(data.viewer.project.translatedText?.text);
	}
	});

It seems like this GraphQL Request needs a targetLanguageSlug and sourceLanguageSlug
In this method, it seems like the param targetLanguageSlug should be sourceLanguageSlug
It is then missing the targetLanguageSlug from request based on the "conflict list column"

[ChxGuillaume]

Hi @simonprev,

Would like to know something regarding the Machine Translation feature.

Are the languages proposed in the inputs supposed to be a Source selection or the other way around?

I thought it was meant to select the source language you wanted to use for translation into the current "context" language 😄
I suppose if it is Target from Source, the source would be the primary language?

Sorry for bothering you with this issue 😅

[simonprev]

Hi @ChxGuillaume ! Yeah the UX for this is not optimal, I see why you thought that the select was the source language.

The way this works is by using the "detect language" of the provider like DeepL and Google Translate. The fix is already in master branch and 1.21.0. The proposed languages in the select are choices "to be translated in". You’re right that it’s pointless since we know the "target" language since we are in the context of a language in the textarea.

This means we should just remove the list of language and make the "translate" icon just send the text with the current textarea language context as the "target" parameter.

That makes sense?

[ChxGuillaume]

Okay yup, get it.
Thanks for the clarification 😄