Coder Social home page Coder Social logo

Comments (6)

mirari avatar mirari commented on June 12, 2024

It's strange to add a rule to the vue-loader, what is the rule?
Normally you just need to run 'npm i vue-fullscreen', and make sure it's in the dependencies of your package.json

from vue-fullscreen.

theochit avatar theochit commented on June 12, 2024

I got an error in the parent application before I added this rule. I thought it was because the component method of importing fullscreen imports a Vue file. It's only a symptom of my problem though, is there a way to build your package into my player so that vue-fullscreen doesnt need to be installed in the parent project? I want to decouple my player from my client so the player can be used elsewhere with no friction. Thanks for the response.

  {
      test: /\.vue?$/,
      include: [ path.resolve(__dirname, 'node_modules/vue-fullscreen')],
      use: 'vue-loader'
  }

from vue-fullscreen.

mirari avatar mirari commented on June 12, 2024

What's the error?
There is no vue file in the dist directory which is the only one that is used.
import VueFullscreen from 'vue-fullscreen' means import VueFullscreen from 'vue-fullscreen/dist/vue-fullscreen.min.js', this file has already been compiled.
————
Declaring vue-fullscreen in the dependencies of your package.json of the player project, other people using your player do not need to explicitly install vue-fullscreen.
————
If you're not using fullscreen-api in a vue project, you don't need 'vue-fullscreen', try this:
https://github.com/sindresorhus/screenfull.js

from vue-fullscreen.

theochit avatar theochit commented on June 12, 2024

It's in my package.json, and to be safe I'm declaring vue-fullscreen this way:

import Fullscreen from 'vue-fullscreen'
import Vue from 'vue'
Vue.use(Fullscreen, {name: 'fullscreen'})

Which works in my player, but in the client I get this error:
Module not found: Error: Can't resolve 'vue-fullscreen' in <path_to_my_player_dist>

Am i missing something?

from vue-fullscreen.

mirari avatar mirari commented on June 12, 2024

If 'vue-fullscreen' is in your player's dependencies, it should be installed together with the player when you run 'npm install your-player', check if it is in the node_modules in the client.

from vue-fullscreen.

theochit avatar theochit commented on June 12, 2024

It wasn't important at the time so I put it off - it was because I wasn't correctly installing the plugin using Vue.use() I was just using the source code directly I guess

from vue-fullscreen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.