miracleblue / atom-single-click-open

Open files with a single click again!

single-click-open package

Open files with a single click again! In tree view and project search results.

notes

This package requires the Allow Pending Pane Items setting to be enabled. If it isn't it will automatically enable the option for you.

MIT © Olmo Kramer

atom-single-click-open's Issues

Editor keeps being focussed beside disabled in options

Since the newest atom update (1.10.2), it seems, that your plugin is broken for that settings option.
Whether "Focus Editor On Open" is checked or not, does not change the behaviour of the editor.

Failed to activate the single-click-open package

Started with Atom 1.12.0-beta0
Opening any document generates this error.

Atom Version: 1.12.0-beta0
Electron Version: 1.3.6
System: Mac OS X 10.11.6
Thrown From: single-click-open package, v0.2.1

Stack Trace

Failed to activate the single-click-open package

At Arguments to CompositeDisposable.add must have a .dispose() method

TypeError: Arguments to CompositeDisposable.add must have a .dispose() method
    at assertDisposable (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:70:13)
    at CompositeDisposable.module.exports.CompositeDisposable.add (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:43:11)
    at Object.activate (/Users/bmiller/.atom/packages/single-click-open/lib/single-click-open.js:28:17)
    at Package.module.exports.Package.activateNow (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:184:19)
    at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:157:32
    at Package.module.exports.Package.measure (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:150:26
    at Package.module.exports.Package.activate (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:147:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:548:21)
    at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:529:29
    at Config.module.exports.Config.transactAsync (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:524:19)
    at PackageManager.module.exports.PackageManager.activate (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:506:46)
    at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/atom-environment.js:783:28

Closing the last open tab with keyboard shortcut (cmd-w) causes error

Stacktrace:

TypeError: Cannot read property 'focus' of undefined
    at /Users/efatsi/.atom/packages/single-click-open/lib/single-click-open.js:56:33
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:346:27
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at Pane.module.exports.Pane.setActiveItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:282:22)
    at Pane.module.exports.Pane.removeItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:560:16)
    at Pane.module.exports.Pane.destroyItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:637:16)
    at Pane.module.exports.Pane.destroyActiveItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:617:12)
    at Workspace.module.exports.Workspace.destroyActivePaneItem (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:692:35)

I can take a look into this later today to find a fix.

Editor won't focus on new tab

Hello there,
first of all: thank you for this addon. :)

My problem is that the "Focus Editor On Open" option is not working. Single click opens the files in a new tab, but does not focus on them. Also, single-click legacy behaviour was to open a file in a new tab, and further single-clicks on other files would replace that tab, this addon keeps opening new tabs?

My atom version:

Atom    : 1.27.0
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0

Addon version is 0.2.2.

I hope I am not missing something obvious.

Thank you.