Coder Social home page Coder Social logo

Comments (6)

miracle2k avatar miracle2k commented on August 19, 2024

The default value is supposed to be True (the thinking being that in production, the output is likely to be sent through a minimizer that will remove comments anyway).

If debug_info is set to None, whether by virtue of it being the default value, or because the user explicitly set it to None, then the default value would be used. I believe equating None with "default, nothing explicitly set" is quite common.

from webassets.

dchaplinsky avatar dchaplinsky commented on August 19, 2024

Unfortunately, yuicompressor do not remove this comments (at least 2.4.6)

from webassets.

miracle2k avatar miracle2k commented on August 19, 2024

Strange, is it giving special treatment to the sass debug comments, or isn't it removing comments at all?

In any case - maybe the default behavior should be based on env.debug/ASSETS_DEBUG.

from webassets.

dchaplinsky avatar dchaplinsky commented on August 19, 2024

Isn't removing comments at all:
@media -sass-debug-info{filename{font-family:}line{font-family:\0000321}}body{line-height:1;color:black;background:white}@media -sass-debug-info{filename{font-family:}line{font-family:\0000326}}ol,ul

In any case - maybe the default behavior should be based on env.debug/ASSETS_DEBUG.

Not sure if it's good idea, sometimes it's handier to use merged files during development, but still control the debug info generated by sass.

from webassets.

dchaplinsky avatar dchaplinsky commented on August 19, 2024

Grrr, github markdown and comments system are killing me

from webassets.

miracle2k avatar miracle2k commented on August 19, 2024

Ah I see now, sass is generating @media at-rules. I thought it included the debug info as a CSS comment. That explains it then.

Not sure if it's good idea, sometimes it's handier to use merged files during development, but still control the debug info generated by sass.

It would only be the default. You could still use sass_filter_instance.debug_info or SASS_DEBUG_INFO to force a particular behavior, just like you can do now.

from webassets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.