Selecting option of select element about mink

[cordoval]

@richardmiller, I have the same problem

looking at this called from here

<?php
    /**
     * Selects option from select field with specified locator.
     *
     * @param   string  $locator    input id, name or label
     *
     * @throws  Behat\Mink\Exception\ElementNotFoundException
     */
    public function selectFieldOption($locator, $value)
    {
        $field = $this->findField($locator);

        if (null === $field) {
            throw new ElementNotFoundException(
                $this->getSession(), 'form field', 'id|name|label|value', $locator
            );
        }

        $field->selectOption($value);
    }

The selectOption is:

<?php
    /**
     * Selects current node specified option if it's a select field.
     *
     * @param   string  $option
     */
    public function selectOption($option)
    {
        $this->getSession()->getDriver()->selectOption($this->getXpath(), $option);
    }

The selectOption method at this level depends on the driver implementation:

<?php
vendor/behat/mink/src/Behat/Mink/Driver/DriverInterface.php
225:    function selectOption($xpath, $value);

vendor/behat/mink/src/Behat/Mink/Driver/GoutteDriver.php
313:     * @see     Behat\Mink\Driver\DriverInterface::selectOption()
315:    public function selectOption($xpath, $value)

vendor/behat/mink/src/Behat/Mink/Driver/SahiDriver.php
366:     * @see     Behat\Mink\Driver\DriverInterface::selectOption()
368:    public function selectOption($xpath, $value)

vendor/behat/mink/src/Behat/Mink/Driver/ZombieDriver.php
454:     * @see     Behat\Mink\Driver\DriverInterface::selectOption()
456:    public function selectOption($xpath, $value)

vendor/behat/mink/src/Behat/Mink/Behat/Context/BaseMinkContext.php
204:    public function selectOption($select, $option)

If we take sahi for instance we find this:

<?php
    /**
     * @see     Behat\Mink\Driver\DriverInterface::selectOption()
     */
    public function selectOption($xpath, $value)
    {
        $type = $this->getAttribute($xpath, 'type');

        if ('radio' === $type) {
            $this->selectRadioOption($xpath, $value);
        } else {
            $this->client->findByXPath($this->prepareXPath($xpath))->choose($value);
        }
    }

And most likely down to the bottom at this level all is implementation dependent.

Therefore the only place where we can swap is up the chain,

<?php
    /**
     * Selects option from select field with specified locator.
     *
     * @param   string  $locator    input id, name or label
     *
     * @throws  Behat\Mink\Exception\ElementNotFoundException
     */
    public function selectFieldOption($locator, $value)
    {
        $field = $this->findField($locator);

        if (null === $field) {
            throw new ElementNotFoundException(
                $this->getSession(), 'form field', 'id|name|label|value', $locator
            );
        }

        //  here we transform $value _if_ $value is the contents of the <option value="x">y</option> tags so $value == y
        //  into $value == x

        $field->selectOption($value);
    }

In order to rule out the ambiguity of this situation we will create another method on the base mink context class, since it seems it keeps BC and also simplifies the code.

<?php
    /**
     * Selects option label in select field with specified id|name|label|value.
     *
     * @When /^(?:|I )select label "(?P<optionLabel>(?:[^"]|\\")*)" from "(?P<select>(?:[^"]|\\")*)"$/
     */
    public function selectOption($select, $optionLabel)
    {
        $select = str_replace('\\"', '"', $select);
        $option = str_replace('\\"', '"', $optionLabel);
        $this->getSession()->getPage()->selectFieldOptionLabel($select, $optionLabel);
    }

And we write selectFieldOptionLabel as:

<?php
    /**
     * Selects option from select field with specified locator.
     *
     * @param   string  $locator    input id, name or label
     * @param   string  $optionLabel    label between option tags       
     * @throws  Behat\Mink\Exception\ElementNotFoundException
     */
    public function selectFieldOptionLabel($locator, $optionLabel)
    {
        $field = $this->findField($locator);

        if (null === $field) {
            throw new ElementNotFoundException(
                $this->getSession(), 'form field', 'id|name|label|value', $locator
            );
        }

        // get $value from $optionLabel
        $value = $field->fromLabelToValue($optionLabel);

        $field->selectOption($value);
    }

@richardmiller there is an optgroup or option named selectors on mink documentation here, in addition to this there is support for nested traversing ... thus we can reuse $field as below

perhaps we can use those to do something like:

<?php
 $optionItems = $field->findAll???();
 foreach $optionItems as $item {
    if($item->getText() == $optionLabel) {
       $valueOption = $item->getValue();
    }
 }

[cordoval]

@richardmiller

see below, can you please help?

<?php
 /**
     * Selects option from select field with specified locator.
     *
     * @param   string  $locator    input id, name or label
     *
     * @throws  Behat\Mink\Exception\ElementNotFoundException
     */
    public function selectFieldOption($locator, $value)
    {
        /* @var \Behat\Mink\Element\NodeElement $field */
        $field = $this->findField($locator);

        if (null === $field) {
            throw new ElementNotFoundException(
                $this->getSession(), 'form field', 'id|name|label|value', $locator
            );
        }

        /* @var \Behat\Mink\Selector\SelectorsHandler $handler */
        $handler = $this->getSession()->getSelectorsHandler();

        $optionElements = $this->findAll('named', array(
            'option', $handler->selectorToXpath('css', 'option')
        ));

        /* @var \Behat\Mink\Element\NodeElement $optionElements */
        foreach ($optionElements as $item) {
            if((string)$item->getText() == $value) {
                //$actualValue = $item->getValue();
                var_export('1');
            }
        }
        $field->selectOption($actualValue);
    }

When I uncomment the //$actualValue = $item->getValue() all stops working

we are almost there but there seems to be recursion I don't understand, can you hint me please?

[mintbridge]

Im not sure this is quite working properly, as it always returns the first option element in the select
If you change:
Behat@173c49d#L1R316
from $select->selectOption('ten'); to be $select->selectOption('thirty'); then i think the unit test will fail

[mintbridge]

It also throws an exception would you try to select an option that contains a space e.g.
When I select "Test 1" from "testselect"