Deprecate `MINIO_SERVER_URL` about minio

[allanrogerr]

@ravindk89 The env var MINIO_SERVER_URL is relevant in scenarios where the minio server and minio console are no longer colocated on a mutual localhost. This var enabled the minio console to communicate with the minio server. These scenarios are still functional and documented here: https://min.io/docs/minio/linux/administration/minio-console.html#configuration

If these scenarios were defined as invalid setups, then MINIO_SERVER_URL would no longer have any meaning.

Your thoughts?

[ravindk89]

The MinIO Console connects to the MinIO Server using an IP address by default. For example, when the MinIO Server starts up, the server logs include a line API: https://<IP ADDRESS 1> https://<IP ADDRESS 2>. The MinIO Console defaults to connecting using <IP ADDRESS 1>.

So I think at some point this changed, and Console talks to Server w/o consideration of that.

If that is true, and we are no longer bound by issues of Console attempting to talk to Server over some other interface, then I think this doesn't matter anymore?

@harshavardhana we had spoken at least briefly about this, but I do want to be very careful in this. To my knowledge today, Console and Server comms are no longer bound by IP/TLS/Hostname-related barriers as they were when that doc was written

[allanrogerr]

It also looks like a valid MINIO_SERVER_URL is required to properly format a share URL; and not use private IP e.g. 127.0.0.1. Not sure where this is documented.

[harshavardhana]

It also looks like a valid MINIO_SERVER_URL is required to properly format a share URL; and not use private IP e.g. 127.0.0.1. Not sure where this is documented.

Not needed anymore

[allanrogerr]

Backlogged until discussion with wider team.

[harshavardhana]

minio/console#3319 this is the first PR

[harshavardhana]

This is mostly complete now; we can stop talking about MINIO_SERVER_URL since the latest release.

[ravindk89]

Fantastic @harshavardhana - that's a great relief :)